Skip to content

fallbackToDestructiveMigration is added - #473

Closed
Faiizii wants to merge 4 commits into
pinchbv:developfrom
Faiizii:develop
Closed

fallbackToDestructiveMigration is added#473
Faiizii wants to merge 4 commits into
pinchbv:developfrom
Faiizii:develop

Conversation

@Faiizii

@Faiizii Faiizii commented Jan 5, 2021

Copy link
Copy Markdown

Hey there!
I created a pull request to allow the fallbackToDestructiveMigration. Please check and review the request if it full fill the standards, and let me know if there's any thing missing or required to explain.

@codecov

codecov Bot commented Jan 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #473 (c343d71) into develop (362625d) will increase coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
+ Coverage    83.63%   84.13%   +0.50%     
===========================================
  Files           69       10      -59     
  Lines         1741      208    -1533     
===========================================
- Hits          1456      175    -1281     
+ Misses         285       33     -252     
Flag Coverage Δ
floor 84.13% <ø> (+0.50%) ⬆️
floor_generator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lib/processor/error/queryable_processor_error.dart
...enerator/lib/writer/transaction_method_writer.dart
...tor/lib/misc/extension/set_equality_extension.dart
...loor_generator/lib/processor/entity_processor.dart
floor_generator/lib/value_object/view.dart
floor_generator/lib/processor/view_processor.dart
..._generator/lib/writer/database_builder_writer.dart
floor_generator/lib/writer/dao_writer.dart
...oor_generator/lib/writer/update_method_writer.dart
...ator/lib/misc/extension/dart_object_extension.dart
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362625d...c343d71. Read the comment docs.

@vitusortner

Copy link
Copy Markdown
Collaborator

The new files and changes in the example directory add a lot of noise to the PR. Do we need them or could we just get rid of them? @Faiizii

@Faiizii

Faiizii commented Jan 6, 2021

Copy link
Copy Markdown
Author

@vitusortner The example (directory) was created with android support lib but flutter latest version using androidx lib for android. So, to support latest versions for both android and iOS, I deleted the both android and iOS folder and executed the flutter create . command, and the flutter created the required files.
If you don't want them to be the part of the repo, we can go with old version of example directory

@wamaeb

wamaeb commented Apr 11, 2021

Copy link
Copy Markdown

Whatever happened to this?

@Faiizii

Faiizii commented Apr 19, 2021

Copy link
Copy Markdown
Author

Whatever happened to this?

the owner did not accept the merge sadly.

@hm-tamim

Copy link
Copy Markdown

Any update on this?

@hm-tamim

Copy link
Copy Markdown

any update on this PR?

@dkaera

dkaera commented Dec 29, 2022

Copy link
Copy Markdown
Collaborator

Hello @hm-tamim
currently not
plan to update and check it out next

@dkaera

dkaera commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

I think fallbackToDestructiveMigration should be managed by a config option during database initialization (not from generated code). It makes it easy to manage, just like it works in the Room Persistence library.
The current implementation is quite outdated and contains a lot of noise unrelated to the implementation of the feature.
If you need this functionality please use this fork

@dkaera dkaera closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants