Skip to content

Add TaskStatus.open as status when creating a new task - #764

Open
SEGVeenstra wants to merge 9 commits into
developfrom
fix/example_initial_status
Open

Add TaskStatus.open as status when creating a new task#764
SEGVeenstra wants to merge 9 commits into
developfrom
fix/example_initial_status

Conversation

@SEGVeenstra

Copy link
Copy Markdown

Fixes #763

@codecov

codecov Bot commented Jul 3, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (a618e06) to head (808f14d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #764   +/-   ##
========================================
  Coverage    91.92%   91.92%           
========================================
  Files           11       11           
  Lines          223      223           
========================================
  Hits           205      205           
  Misses          18       18           
Flag Coverage Δ
floor 91.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephanmantel

Copy link
Copy Markdown
Contributor

Even though I like most of the formatting changes, it got me thinking is there an agreed upon style guide for this project? And if not, should there be?

stephanmantel
stephanmantel previously approved these changes Jul 3, 2023
@SEGVeenstra

Copy link
Copy Markdown
Author

I had to add an analyzer exception to make the tests pass.
This happens to resolve #742 😄

stephanmantel
stephanmantel previously approved these changes Feb 29, 2024
# Conflicts:
#	example/lib/main.dart
#	example/pubspec.lock
#	floor/pubspec.lock
#	floor_annotation/pubspec.lock
#	floor_generator/pubspec.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

In the example, a task is created with status: null instead of open

3 participants