Skip to content

⚡ Bolt: Cache isDocker() synchronous filesystem checks - #18

Draft
piyyy314 wants to merge 1 commit into
mainfrom
perf-is-docker-cache-16526380002677426203
Draft

⚡ Bolt: Cache isDocker() synchronous filesystem checks#18
piyyy314 wants to merge 1 commit into
mainfrom
perf-is-docker-cache-16526380002677426203

Conversation

@piyyy314

Copy link
Copy Markdown
Owner

💡 What:

The helper function isDocker() determines if the current runtime environment is a Docker container by checking /.dockerenv and /proc/self/cgroup synchronously via the filesystem. This optimization caches the result inside a module-level variable so that successive checks during a single execution bypass filesystem queries.

🎯 Why:

Environment checks like isDocker are called multiple times in various workflows of the Snyk CLI lifecycle (such as during arg parsing, analytics collection, credentials verification, and request queries). Querying the filesystem synchronously over and over degrades overall performance and increases disk overhead.

📊 Impact:

  • Bypasses redundant synchronous fs.statSync() and fs.readFileSync() calls during a single process lifetime.
  • Improves CLI responsiveness, especially on environments with high I/O latency or networked filesystems.

🔬 Measurement:

  • Unit tests (is-docker.spec.ts) mock state and call resetIsDockerCache() in beforeEach to guarantee test isolation and verify correctness. All unit tests and formatting checks pass seamlessly.

PR created automatically by Jules for task 16526380002677426203 started by @piyyy314

Cache the results of `isDocker()` within a module-level variable to prevent redundant synchronous filesystem I/O calls (`fs.statSync` and `fs.readFileSync`) during the CLI execution lifecycle.
Export a `resetIsDockerCache` helper for unit tests to maintain isolation.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d7043772-03e3-4e79-85e9-7bd831678bf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@piyyy314

Copy link
Copy Markdown
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant