🛡️ Sentinel: Fix command injection in analytics sources check

[piyyy314]

🛡️ Sentinel: Fix command injection vulnerability in analytics package installation check

🚨 Severity: HIGH
💡 Vulnerability: isInstalled in src/lib/analytics/sources.ts executed system commands (which, where, adb) by concatenating user/system inputs into shell strings passed directly to child_process.exec.
🎯 Impact: Attackers able to influence command arguments could execute arbitrary shell commands in the context of the running process via shell metacharacters.
🔧 Fix:

• Refactored runCommand and isInstalled to use child_process.execFile with argument vectors, neutralizing shell command expansion.
• Corrected promise handling in runCommand to reject on execution error so command checks reliably return false on missing or invalid executables.
  ✅ Verification: Added unit tests in test/jest/unit/analytics-sources.spec.ts mocking execFile and verifying safe parameter arrays and command injection resistance.

---

PR created automatically by Jules for task 4761026848835372050 started by @piyyy314

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ebda7c91-fa80-44a9-be0e-479e7aa35a37

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[piyyy314]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.