Skip to content

⚡ Bolt: Optimize debug file filtering in find-files #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
piyyy314 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

⚡ Bolt: Optimize debug file filtering in find-files #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c13a8e
perf(find-files): guard debug array operations and use Set for lookup
piyyy314 Aug 17, 2026
f13cbc4
perf(find-files): guard debug array operations and use Set for lookup
piyyy314 Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/lib/find-files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,19 @@ export async function find(findConfig: FindFilesConfig): Promise<FindFilesRes> {
foundAll.push(fileFound);
}
}
const filteredOutFiles = foundAll.filter((f) => !found.includes(f));
if (filteredOutFiles.length) {
debug(
`Filtered out ${filteredOutFiles.length}/${
foundAll.length
} files: ${filteredOutFiles.join(', ')}`,
);
// Performance optimization: debug filtering is guarded by debug.enabled to avoid
// O(N^2) array iterations and memory allocations when debug logging is off.
// When debug is enabled, converting `found` to a Set makes lookups O(1) instead of O(N).
if (debug.enabled) {
const foundSet = new Set(found);
const filteredOutFiles = foundAll.filter((f) => !foundSet.has(f));
if (filteredOutFiles.length) {
debug(
`Filtered out ${filteredOutFiles.length}/${
foundAll.length
} files: ${filteredOutFiles.join(', ')}`,
);
}
}
return {
files: filterForDefaultManifests(found, config.featureFlags),
Expand Down