🛡️ Sentinel: Remediate Command Injection in analytics sources

[piyyy314]

🚨 Severity: HIGH

💡 Vulnerability

src/lib/analytics/sources.ts previously used child_process.exec in runCommand to execute binary lookup commands (such as which or where), executing commands within an OS shell environment.

🎯 Impact

If isInstalled or runCommand were invoked with unsanitized arguments, shell metacharacters could lead to arbitrary command execution.

🔧 Fix

1. Replaced child_process.exec with child_process.execFile in runCommand.
2. Refactored isInstalled to pass the binary executable and arguments as separate array elements to runCommand rather than string concatenation.
3. Updated runCommand to reject promises on execution error to properly report missing binaries.

✅ Verification

1. Added unit tests for runCommand and isInstalled in test/jest/unit/analytics-sources.spec.ts.
2. Verified unit tests pass cleanly using npx jest test/jest/unit/analytics-sources.spec.ts.

---

PR created automatically by Jules for task 5435016672085555611 started by @piyyy314

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[piyyy314]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: acdba01a-aa03-418e-ad24-69c9cb4365ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}