Skip to content

⚡ Bolt: Optimize array inclusion lookups in multi-project and Gradle plugins - #29

Draft
piyyy314 wants to merge 2 commits into
mainfrom
bolt-optimize-array-includes-in-plugins-9493093956918352675
Draft

⚡ Bolt: Optimize array inclusion lookups in multi-project and Gradle plugins#29
piyyy314 wants to merge 2 commits into
mainfrom
bolt-optimize-array-includes-in-plugins-9493093956918352675

Conversation

@piyyy314

Copy link
Copy Markdown
Owner

💡 What:

Optimized array inclusion checks in workspace processing (filterOutProcessedWorkspaces in src/lib/plugins/get-multi-plugin-result.ts) and Gradle manifest warning detection (warnSomeGradleManifestsNotScanned in src/lib/plugins/get-deps-from-plugin.ts) by converting scanned project array references into Set instances before iterative filtering/loops.

🎯 Why:

Previously, both functions used Array.prototype.includes() inside loops/filters over scanned project target files. For projects with $S$ scanned projects and $T$ target files (or $D$ detected Gradle files), this resulted in $O(S \times T)$ linear search performance.

📊 Impact:

  • Reduces lookup complexity from $O(S \times T)$ to $O(S + T)$ for multi-project scans and workspace filtering.
  • Eliminates linear search overhead when filtering scanned projects across large workspace structures (e.g., Yarn/npm/pnpm workspaces with hundreds of sub-projects).

🔬 Measurement:

  • Verified via unit tests (test/jest/unit/lib/plugins/get-multiplugin-result.spec.ts and test/jest/unit/lib/plugins/warn-some-gradle-manifests-not-scanned.spec.ts).

PR created automatically by Jules for task 9493093956918352675 started by @piyyy314

…plugins

Convert scanned project file arrays to Sets in `filterOutProcessedWorkspaces` and `warnSomeGradleManifestsNotScanned` to reduce lookup complexity from O(S * T) to O(S + T).

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 02e45ea1-b6da-41e8-8533-8224fe5790da

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@piyyy314

piyyy314 commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

…plugins

Convert scanned project file arrays to Sets in `filterOutProcessedWorkspaces` and `warnSomeGradleManifestsNotScanned` to reduce lookup complexity from O(S * T) to O(S + T).

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant