🛡️ Sentinel: obfuscate sensitive tokens in CLI arguments - #35
Conversation
…logs Redact sensitive token flags (`token` and `tfc-token`) alongside `username` and `password` in `obfuscateArgs` to prevent sensitive credentials from leaking into analytics and telemetry payloads. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…logs Redact sensitive token flags (`token` and `tfc-token`) alongside `username` and `password` in `obfuscateArgs` to prevent sensitive credentials from leaking into analytics and telemetry payloads. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Summary of Security Enhancement
obfuscateArgsinsrc/lib/utils.tsonly redactedusernameandpasswordCLI flags. Other sensitive CLI options such astokenandtfc-tokenwere left unmasked in command args, posing a risk of credential leakage in analytics or telemetry event logging.obfuscateArgsto iterate over a list of sensitive keys (['username', 'password', 'token', 'tfc-token']) and obfuscate them to${key}-set.test/jest/unit/lib/util.spec.tscoveringtokenandtfc-tokenobfuscation, and verified all unit tests pass withnpx jest test/jest/unit/lib/util.spec.ts.PR created automatically by Jules for task 1453252894358789402 started by @piyyy314