⚡ Bolt: Optimize HTML entity unescaping in markdown renderer - #46
⚡ Bolt: Optimize HTML entity unescaping in markdown renderer#46piyyy314 wants to merge 2 commits into
Conversation
Pre-compile `HTML_UNESCAPE_RE` at the module level and perform a single-pass string replacement using an unescape map rather than creating new RegExp objects and iterating over entries on every call. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Pre-compile `HTML_UNESCAPE_RE` at the module level and perform a single-pass string replacement using an unescape map rather than creating new RegExp objects and iterating over entries on every call. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
⚡ Bolt: Optimize HTML entity unescaping in markdown renderer
💡 What:
Optimized the
unescapefunction insrc/cli/commands/help/markdown-renderer.tsby pre-compiling a unified regular expression (HTML_UNESCAPE_RE) at module load time and replacing the 7 individualRegExpobject allocations and 7 separate string scans perrenderMarkdowncall with a single-pass regex replace against a lookup map.🎯 Why:
Previously,
unescapeperformedObject.entries(htmlUnescapes).forEach(...)on every rendered markdown document/string, instantiatingnew RegExp(escapedChar, 'g')for each key and scanning the input string 7 times sequentially.📊 Impact:
RegExpobject allocations perrenderMarkdown()invocation.🔬 Measurement & Verification:
test/jest/unit/cli/commands/help/markdown-renderer.spec.ts.npx jest test/jest/unit/cli/commands/help/markdown-renderer.spec.ts.npm run lint:jspasses with zero warnings/errors.PR created automatically by Jules for task 18162041058769781582 started by @piyyy314