Skip to content

⚡ Bolt: Optimize HTML entity unescaping in markdown renderer - #46

Draft
piyyy314 wants to merge 2 commits into
mainfrom
bolt-optimize-markdown-unescape-18162041058769781582
Draft

⚡ Bolt: Optimize HTML entity unescaping in markdown renderer#46
piyyy314 wants to merge 2 commits into
mainfrom
bolt-optimize-markdown-unescape-18162041058769781582

Conversation

@piyyy314

Copy link
Copy Markdown
Owner

⚡ Bolt: Optimize HTML entity unescaping in markdown renderer

💡 What:

Optimized the unescape function in src/cli/commands/help/markdown-renderer.ts by pre-compiling a unified regular expression (HTML_UNESCAPE_RE) at module load time and replacing the 7 individual RegExp object allocations and 7 separate string scans per renderMarkdown call with a single-pass regex replace against a lookup map.

🎯 Why:

Previously, unescape performed Object.entries(htmlUnescapes).forEach(...) on every rendered markdown document/string, instantiating new RegExp(escapedChar, 'g') for each key and scanning the input string 7 times sequentially.

📊 Impact:

  • Reduces string passes from 7 passes to 1 pass ($O(N)$ string traversal).
  • Eliminates 7 dynamic RegExp object allocations per renderMarkdown() invocation.

🔬 Measurement & Verification:

  • Added unit tests in test/jest/unit/cli/commands/help/markdown-renderer.spec.ts.
  • Verified tests pass with npx jest test/jest/unit/cli/commands/help/markdown-renderer.spec.ts.
  • Verified npm run lint:js passes with zero warnings/errors.

PR created automatically by Jules for task 18162041058769781582 started by @piyyy314

Pre-compile `HTML_UNESCAPE_RE` at the module level and perform a
single-pass string replacement using an unescape map rather than
creating new RegExp objects and iterating over entries on every call.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@piyyy314

piyyy314 commented Aug 26, 2026

Copy link
Copy Markdown
Owner Author

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Pre-compile `HTML_UNESCAPE_RE` at the module level and perform a
single-pass string replacement using an unescape map rather than
creating new RegExp objects and iterating over entries on every call.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant