🛡️ Sentinel: Fix command injection risk in clipboard copy helper - #53
🛡️ Sentinel: Fix command injection risk in clipboard copy helper#53piyyy314 wants to merge 1 commit into
Conversation
Refactor src/cli/copy.ts to use execFileSync with discrete argument arrays rather than execSync string invocation. This prevents shell subshell spawning and mitigates potential OS command injection risks. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚨 Severity
MEDIUM
💡 Vulnerability
src/cli/copy.tsexecuted clipboard programs viaexecSync(program, { input: str }). RunningexecSyncspawned a subshell (/bin/shorcmd.exe). On Linux, passing'xclip -selection clipboard'as a single string to shell execution introduced unnecessary shell subshell overhead and command evaluation risks.🎯 Impact
Executing binaries through a shell subshell can expose applications to command injection if arguments or program strings are derived from untrusted input or shell special characters.
🔧 Fix
Replaced
execSyncwithexecFileSyncusing discrete binary executable and argument arrays (pbcopyfor macOS,clipfor Windows,xclipwith['-selection', 'clipboard']for Linux).✅ Verification
Added unit tests in
test/jest/unit/cli/copy.spec.tscovering Darwin, Linux, Windows, and unsupported platforms to verifyexecFileSyncarguments. Ran ESLint and Prettier.PR created automatically by Jules for task 8458422898227472615 started by @piyyy314