Promote fixes from the Plex client embed (layout, virtuallist, focus, reanimated, rendering)#107
Merged
Merged
Conversation
…ate-attached nodes
…ad of dropping it
…t on partial pushes
DouweBos
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch of framework fixes developed against the Plex client's in-repo
react-lightningembed and validated there before promotion. This is the full burst (63 commits, individual commits preserved) since we vendoredmainGrouped by area:
Yoga / layout
aspectRatioparsing, dropped-flex reset to yoga defaults, synchronous text measurement +flushLayout/settled, same-parentinsertChildtreated as a move so reorders re-layout.VirtualList
estimatedItemSize(sizes come fromoverrideItemLayoutor measurement), reveal driven off yoga-settled instead of timers, withhold rows until measured height settles, re-push cell cross-size after a data reset, skip stale visible indices after a sync shrink, viewport capped at stage edge +scrollSnapAlign, header/footer cross-axis pinned when width is definite, stop cross-size ratcheting off the parent cell.Focus / spatial nav
autoFocus+destinations-on-arrival,getLayoutref API +skipChildFocusScroll, skip empty focus groups, clamp cross-axis distance to the target span, expose focused state to function children, pointer-suppress aware focus-follow.Reanimated
animateStyleso composed animations play, composed sequence/repeat/delay on the node, honor caller easing inwithTiming, infer hook deps by tracking shared-value reads, skip no-op style animations, partial style pushes so static flex props survive.Rendering / misc
flattenLayoutViews) with placeholder fold-through, rounded clipping via stencilclipRadius, withhold paint until first layout, Image array-style flattening + border shaders on live nodes, key-event normalization + held-key auto-repeat, font-atlas url resolution before the inlined worker, drop unresolvable css keyword colors,CanvasRootexport for react-dom-free mount, glyph fallback advance measurement,@lightningjs/renderer3.1.1 bump.Commits are individually scoped and messaged; each applies cleanly on
main