Repository navigation
Conversation
24b16ec to
ffa0daf
Compare
|
Looks good to me. One issue I had with pyfilesystem is that the jinja2 integration was very out of date and required an ancient jinja2 version. Is there anything suitable for fs-next? If not, it's fine but influences my long-term planning. |
|
Thanks for the review! fs-next doesn't currently ship a Jinja2 loader. The latest jinja2-fsloader release still requires A small custom I'd keep this PR focused on the dependency swap. If useful, I can prepare a separate PR adding include support to Tilekiln and addressing the TODO in |
|
This PR looks good to me if you're ready to take it out of draft |
|
Thanks, marked as ready for review. |
Change
Replace
fswithfs-next>=0.1.1,<0.2and remove thesetuptools<82runtime dependency, then regenerate uv.lock. Existingimport fs, MemoryFS and OSFS usage remains unchanged; no application code changes are needed. This offers a compatible migration option for #73 without rewriting filesystem calls.I maintain FS Next, an independent maintenance fork rather than an official PyFilesystem release. It retains the
fsimport API and requires Python >=3.10, matching tilekiln's minimum. Its published-original regression suite and modern Python matrix are documented here: https://github.com/kmsk99/fs-next/blob/v0.1.1/docs/release-0.1.1.md . The 0.1.x upper bound keeps this proposal within the documented compatibility series.Validation
load_configwith an external SQL template passes, with neitherfsnorsetuptoolsinstalled as distributions.--platform linuxpasses all 25 source files.os.sched_getaffinityAttributeError; native-platform mypy reports the corresponding six errors. This PR does not claim to fix macOS CLI support. Live PostgreSQL/PostGIS integration has not been run locally; the existing storage unit tests use fake connections.The lockfile also normalizes exceptiongroup's typing-extensions marker during uv regeneration; no unrelated package versions were upgraded. Users should create a fresh environment for the migration because
fsandfs-nextown overlapping module files.This is a draft pending Linux CI verification and maintainer feedback. The fork did not create an Actions run for the branch push; Linux-targeted mypy above is not a Linux runtime test.