alt build - #760
Closed
MattWellie wants to merge 2 commits into
Closed
Conversation
MattWellie
requested review from
Alexander-Stuckey and
rameshka
and removed request for
a team
July 15, 2026 00:28
Alexander-Stuckey
left a comment
Alexander-Stuckey
left a comment
Contributor
There was a problem hiding this comment.
Just one comment on something that I'm not familiar with
Comment on lines
20
to
+21
| run: | | ||
| pip install . | ||
| pip install -r requirements-dev.txt | ||
| pip install ".[dev,test]" |
Contributor
There was a problem hiding this comment.
@violetbrina is this where we could use uv sync --extra dev --extra test?
Contributor
Author
There was a problem hiding this comment.
I believe so. The current uv.lock (not committed) looks like
...
[package.optional-dependencies]
dev = [
{ name = "bump2version" },
{ name = "mypy" },
{ name = "pre-commit" },
{ name = "pylint" },
{ name = "ruff" },
{ name = "toml" },
]
test = [
{ name = "pytest" },
{ name = "pytest-mock" },
]
...
and that uv sync command works as expected
MattWellie
commented
Jul 15, 2026
| @deprecated(reason='Use cpg_utils.dataproc.setup_dataproc instead') | ||
| def setup_dataproc(*args, **kwargs): # noqa: ANN002, ANN003 | ||
| from cpg_utils.dataproc import setup_dataproc as _setup_dataproc | ||
| from cpg_utils.dataproc import setup_dataproc as _setup_dataproc # noqa: PLC0415 |
Contributor
Author
There was a problem hiding this comment.
I would be very ok with removing all these deprecated methods - we don't use them, so we don't need to soft fail
Contributor
Author
|
Probably irrelevant WRT #761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes requirements-dev.txt, and avoids using it in CI build
Does not fix all the linting errors, but does prevent the linting workflow from throwing setup errors