Core: Resetting gpt targeting on bid won - #15398
Conversation
|
This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8ade8add9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
mkomorski
changed the title
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 309ff9bc69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 309ff9bc69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d181822a0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| events.on(EVENTS.AUCTION_END, ({ auctionId }) => { | ||
| unlockGptSlotsForAuction(auctionId); |
There was a problem hiding this comment.
Fresh evidence in this revision is that the new AUCTION_END handler deletes the only guard, but src/auction.ts emits AUCTION_END before the bids-back callback where publishers normally call setTargetingForGPTAsync(). In that timing, a delayed BID_WON from an older auction that fires after auction B ends but after B's targeting is installed (or before the GPT refresh) sees no lock and runs presetGPTTargeting([adUnitCode]), clearing B's valid hb_* keys; keep the guard tied to the auction/targeting that is currently installed rather than removing it at AUCTION_END.
Useful? React with 👍 / 👎.
2 participants
Attaches
presetGPTTargetingtoBID_WONeventType of change
Description of change
Closes #14943
Other information