Skip to content

Various bidder adapters: refactor bidder COPPA config access - #15462

Open
patmmccann wants to merge 5 commits into
masterfrom
codex/refactor-bidders-to-remove-getconfig-for-coppa
Open

Various bidder adapters: refactor bidder COPPA config access#15462
patmmccann wants to merge 5 commits into
masterfrom
codex/refactor-bidders-to-remove-getconfig-for-coppa

Conversation

@patmmccann

@patmmccann patmmccann commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Motivation

  • Reduce direct use of config.getConfig('coppa') inside bidder modules and prefer the enriched OpenRTB placement-level signal bidderRequest.ortb2.regs.coppa with a compatibility fallback.
  • Ensure bidder code reads COPPA from auction/ORTB signals so adapters behave correctly with Prebid core enrichment and consent handlers.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4af5fb8ed3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/aidemBidAdapter.js
@patmmccann patmmccann changed the title Core: refactor bidder COPPA config access Various bidder adapters: refactor bidder COPPA config access Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Some adapters in this PR do not follow Prebid naming conventions.
Module adkernelAdnBidAdapter defines bidder code adkernelAdn, which contains uppercase or non-alphanumeric characters
Module appnexusBidAdapter defines bidder alias appnexusAst, which contains uppercase or non-alphanumeric characters
Module gridBidAdapter defines bidder alias gridNM, which contains uppercase or non-alphanumeric characters

  • Module adkernelAdnBidAdapter defines bidder code adkernelAdn, which conflicts with:
    • bidder code adkernel defined in module adkernelBidAdapter
  • Module adkernelAdnBidAdapter defines bidder alias engagesimply, which conflicts with:
    • bidder alias engageadx defined in module adkernelBidAdapter
    • bidder code engageya defined in module engageyaBidAdapter
  • Module adkernelAdnBidAdapter defines bidder alias adpluto_dsp, which conflicts with:
    • bidder alias adpluto defined in module adkernelBidAdapter
  • Module adkernelBidAdapter defines bidder code adkernel, which conflicts with:
    • bidder code adkernelAdn defined in module adkernelAdnBidAdapter
  • Module adkernelBidAdapter defines bidder alias oftmediahb, which conflicts with:
    • bidder alias oftmedia defined in module msftBidAdapter
  • Module adkernelBidAdapter defines bidder alias audiencemedia, which conflicts with:
    • bidder code audiencerun defined in module audiencerunBidAdapter
  • Module adkernelBidAdapter defines bidder alias waardex_ak, which conflicts with:
    • bidder code waardex defined in module waardexBidAdapter
  • Module adkernelBidAdapter defines bidder alias engageadx, which conflicts with:
    • bidder alias engagesimply defined in module adkernelAdnBidAdapter
    • bidder code engageya defined in module engageyaBidAdapter
  • Module adkernelBidAdapter defines bidder alias converge, which conflicts with:
    • bidder code conversant defined in module conversantBidAdapter
  • Module adkernelBidAdapter defines bidder alias displayioads, which conflicts with:
    • bidder code displayio defined in module displayioBidAdapter
  • Module adkernelBidAdapter defines bidder alias rtbdemand_com, which conflicts with:
    • bidder alias rtbdemand defined in module limelightDigitalBidAdapter
  • Module adkernelBidAdapter defines bidder alias adpluto, which conflicts with:
    • bidder alias adpluto_dsp defined in module adkernelAdnBidAdapter
  • Module adkernelBidAdapter defines bidder alias revbid, which conflicts with:
    • bidder alias revbidortb defined in module revantageBidAdapter
  • Module adkernelBidAdapter defines bidder alias smartyexchange, which conflicts with:
    • bidder code smartyads defined in module smartyadsBidAdapter
    • bidder code smartytech defined in module smartytechBidAdapter
  • Module adkernelBidAdapter defines bidder alias appmonsta, which conflicts with:
    • bidder code appMonstaMedia defined in module appMonstaMediaBidAdapter
  • Module bmtmBidAdapter defines bidder alias brightmountainmedia, which conflicts with:
    • bidder alias brightcom defined in module omsBidAdapter
  • Module gridBidAdapter defines bidder alias adlivetech, which conflicts with:
    • bidder alias adliveplus defined in module luceadBidAdapter
  • Module mediafuseBidAdapter defines bidder code mediafuse, which conflicts with:
    • bidder code mediaforce defined in module mediaforceBidAdapter
  • Module waardexBidAdapter defines bidder code waardex, which conflicts with:
    • bidder alias waardex_ak defined in module adkernelBidAdapter

@github-actions

This comment was marked as off-topic.

@patmmccann
patmmccann marked this pull request as draft August 5, 2026 17:54
@barecheck

barecheck Bot commented Aug 7, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 91.14%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
modules/adagioBidAdapter.js86, 293-295, 445, 487
modules/adkernelAdnBidAdapter.js95, 193, 200, 205
modules/adkernelBidAdapter.js325-327, 335-336, 424, 492, 495, 533, 557, 597, 605
modules/adrelevantisBidAdapter.js174-177, 201, 203-206, 238, 242-243, 245-246, 256-258, 264-266, 278, 350-351, 353, 401, 418, 425, 431, 435, 441, 444, 447, 450, 454
modules/adyoulikeBidAdapter.js87, 113, 252, 258-259, 270, 371, 373, 442
modules/aidemBidAdapter.js129
modules/alkimiBidAdapter.js154, 185, 189-191, 193-194, 196-198, 201, 203, 258-259, 278
modules/amxBidAdapter.js43, 56, 89, 94-95, 139, 151-152, 208, 238, 274-275, 284, 291, 383-384, 386, 427, 453, 466, 481, 520, 539, 590
modules/appnexusBidAdapter.js207-208, 210, 227, 262, 293, 412-415, 433-435, 443-444, 488, 490-493, 527, 531-532, 534-535, 644-645, 647, 805, 862, 868, 871, 874, 880, 965-966, 1011, 1058, 1061-1064, 1070, 1075-1078, 1089, 1093-1096, 1098-1101, 1138, 1187-1190, 1198, 1200-1202, 1210-1212, 1214-1216, 1228, 1255
modules/bliinkBidAdapter.js33, 181, 199, 223
modules/bmtmBidAdapter.js22, 67
modules/carodaBidAdapter.js102-103, 130
modules/connatixBidAdapter.js149, 184, 277, 378, 380-382, 385-387
modules/cpmstarBidAdapter.js61-64, 110, 113, 146-147, 177-180, 182-183
modules/datablocksBidAdapter.js81, 86, 92, 94, 97-98, 102-104, 107, 109, 116, 119, 121, 159, 162, 205, 234, 254, 260, 308, 310-311, 326, 353, 374, 382, 418
modules/datawrkzBidAdapter.js294, 524, 540-541, 571, 581, 616, 621-622, 624
modules/distroscaleBidAdapter.js25, 30-31, 69, 77, 107-108, 141, 143-144, 146, 184, 191, 196, 202, 213, 218, 224, 227, 233, 275
modules/dsp_genieeBidAdapter.js42, 49
modules/eightpodBidAdapter.js135, 184, 218-220, 223
modules/fluctBidAdapter.js82, 210
modules/gridBidAdapter.js83, 106, 184, 203, 216, 223-224, 355, 368-369, 371-372, 374, 404-405, 407, 440, 482-483, 564, 585-588, 606, 609, 634, 636-637, 684, 693, 699-700, 708, 714-715, 717, 720
modules/gumgumBidAdapter.js166, 168-171, 270-271, 424-426, 428, 503-505, 543, 601-602, 654, 713, 771-774, 776
modules/improvedigitalBidAdapter.js230-231, 346, 352-353, 363
modules/insticatorBidAdapter.js20, 24, 26-28, 35-41, 46-47, 49, 73, 85-86, 119, 128, 132, 141, 145, 188-190, 214, 236, 353, 357, 413, 644-645, 658, 674, 681, 762
modules/intenzeBidAdapter.js74, 287-289, 330-333, 340-341, 343
modules/ixBidAdapter.js232, 235, 265-266, 389, 461, 525, 545, 618, 712, 1500-1505, 1507, 1526-1527, 1531-1532, 1565, 1592-1593, 1623-1624, 1628-1629, 1699, 1710, 1765, 1780, 1788-1790, 1792
modules/jwplayerBidAdapter.js59, 81, 231, 254-257, 260-261, 264-265, 270-271, 274-275, 278-279, 282, 291, 296, 343, 348, 357, 374, 378, 382, 389, 398-402, 405-406
modules/kubientBidAdapter.js24, 123, 167, 175
modules/livewrappedBidAdapter.js109, 251, 271
modules/lkqdBidAdapter.js84-85, 89, 95-96, 106, 111
modules/marsmediaBidAdapter.js143, 237, 260-261, 265, 283-286, 289, 316, 365
modules/mediafuseBidAdapter.js94-97, 99, 103-106, 110-111, 144, 146, 270, 555, 592, 607, 610, 646, 696, 700-701, 703-706, 714-717, 720, 725-728, 731, 736-737, 742, 747-757, 760, 782, 954-964, 969-970
modules/mediakeysBidAdapter.js69, 95, 98, 114-115, 132-133, 220, 250-251, 276, 651, 757
modules/medianetBidAdapter.js83, 118, 132, 142-144, 232, 242, 276, 298, 383, 421-422, 432-434
modules/nobidBidAdapter.js43, 92, 97, 102, 132, 182-183, 190-192, 198, 210, 218, 224, 246-247, 286, 329, 332, 335, 346-353, 355, 358-368, 405-407, 415-416, 464, 468-470, 473-476
modules/operaadsBidAdapter.js202, 210-211, 686, 826-827, 836-838, 840-842, 856
modules/outbrainBidAdapter.js49, 53, 57, 136-137, 159-160, 214, 223, 287-288, 307-309, 363, 371-375, 383-385, 388-391, 394, 401-402, 404, 406, 420
modules/ozoneBidAdapter.js126-127, 142, 170, 211-212, 215, 219-220, 489, 613, 650, 685-687, 729-730, 732, 785, 878-879, 895, 897-898, 905, 973, 980-983
modules/pixfutureBidAdapter.js61, 65-66, 68-75, 78-80, 98, 111-112, 114-118, 122-123, 128, 156, 169-170, 172-175, 180, 192, 205, 216, 226-227, 230-231, 237-238, 245, 253, 264, 276, 280, 284, 289, 292, 295, 298, 301, 304, 307, 313, 319-320, 323-324, 326-327, 341-342, 348, 358
modules/pubgeniusBidAdapter.js211, 228-229
modules/pwbidBidAdapter.js160-161, 165-166, 222, 227, 231, 246, 251, 260, 276, 341, 343, 360, 363, 366-367, 385, 399, 416-417, 461, 464, 488, 494, 560, 572, 592, 594, 607, 633, 669-674, 709, 728, 733, 747, 758, 760, 764, 766, 775, 814, 826, 828-830, 832-834, 854-855, 872-873, 904-905, 951-952, 957-958, 966-967, 972, 991, 995, 999
modules/valuadBidAdapter.js27, 141, 155, 162-163
modules/vidoomyBidAdapter.js23-24, 100, 108, 180-181, 194-195, 203, 232-233, 269, 275, 281-282
modules/vrtcalBidAdapter.js50, 94-95, 113, 145-146, 150-151
modules/waardexBidAdapter.js16-17, 42-43, 76, 80, 124, 165, 190-191, 202, 230, 269, 271-272, 274, 280

@patmmccann
patmmccann marked this pull request as ready for review August 7, 2026 16:32

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ac2fa0196

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/livewrappedBidAdapter.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant