Core: optionally drop retained auction data - #15474
Open
patmmccann wants to merge 2 commits into
Open
Conversation
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa58abae1f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Barecheck - Code coverage reportTotal: 91.17%Your code coverage diff: 0.01% ▴ Uncovered files and lines
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal here is to continue stalled #15267 which hasn't made recent progress yet is known to be quite helpful
cc @bbaresic
Motivation
Description
auctionOptions.cleanupAuctionData(default false) to gate dropping request-only fields after auction callbacks; implemented insrc/auction.tswithdropRetainedRequestFields()to removeortb2,userId,userIdAsEids,params,mediaTypes, RTD, and similar fields while retaining necessary videocontext/useCacheKeyand renderer when present.libraries/analyticsAdapter/AnalyticsAdapter.tsby deep-cloning arrays and bid-like objects so debounced analytics always see the original data at event time (BID_TIMEOUT,BID_RESPONSE,NO_BID,AUCTION_INITcoverage added/updated in tests).guardTidscleanup and use-scoped guarding aroundbuildRequests/validatepaths insrc/adapters/bidderFactory.tsso TID proxy caches do not leak; also addclear()for the memoized proxy cache.userIdfrom S2S copies insrc/adapterManager.tsto avoid leaking publisher-side userId in server-side payloads.registerDeletionlistener registration inmodules/consentManagementUsp.tsso the event listener is registered at most once and reset onresetConsentData().src/storageManager.tsso transient failures do not poison future checks; exposecanSetCookie.clear()for tests.BID_TIMEOUT, and S2S/userId handling (changes intest/spec/auctionmanager_spec.js,test/spec/AnalyticsAdapter_spec.js,test/spec/unit/core/adapterManager_spec.js, plus small updates elsewhere).Testing
npx eslint --cache --cache-strategy content <files>and the lint pass completed successfully.npx gulp test --nolint --file test/spec/AnalyticsAdapter_spec.js,npx gulp test --nolint --file test/spec/auctionmanager_spec.js,npx gulp test --nolint --file test/spec/modules/consentManagementUsp_spec.js, andnpx gulp test --nolint --filefor the updated unit specs; all executed specs passed locally.git diff --checkreturned clean and staged the changes; changes were committed locally as the branch update (PR creation step not available in this environment).Codex Task