Skip to content

New bid adapter: advertronic - #15475

Merged
patmmccann merged 3 commits into
prebid:masterfrom
advertronic:new-adapter-advertronic
Aug 9, 2026
Merged

New bid adapter: advertronic#15475
patmmccann merged 3 commits into
prebid:masterfrom
advertronic:new-adapter-advertronic

Conversation

@advertronic

Copy link
Copy Markdown
Contributor

Type of change

  • New bidder adapter

Description of change

New bid adapter for Advertronic SSP (banner and video).

  • Thin adapter built on the ortbConverter library; the endpoint speaks plain OpenRTB 2.x.

  • Outstream video is rendered by our own renderer (loaded from Advertronic servers) unless the publisher supplies one on the ad unit.

  • Bid prices are net to the publisher, currency is RUB (documented on the bidder page).

  • Single iframe user sync; the partner list and frequency capping are handled server-side.

  • Test parameters in modules/advertronic.md consistently return a static test creative from any location.

  • contact email of the adapter maintainer: info@advertronic.io

  • official adapter submission

  • unit tests added (test/spec/modules/advertronicBidAdapter_spec.js)

Docs PR: (link will be added right after it is opened)

@advertronic

Copy link
Copy Markdown
Contributor Author

Docs PR: prebid/prebid.github.io#6694

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a9cdffd1a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/advertronicBidAdapter.js Outdated
Comment thread modules/advertronicBidAdapter.js
@advertronic

Copy link
Copy Markdown
Contributor Author

Both suggestions addressed in 3429a65: dropped the explicit content type (auction POST is now a simple request, no preflight) and added the bidder params .d.ts.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

  • modules/advertronicBidAdapter.js

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

  • Changes to modules/advertronicBidAdapter.js may need:
    • es.array.push
  • Changes to test/spec/modules/advertronicBidAdapter_spec.js may need:
    • es.iterator.constructor
    • es.iterator.find
    • esnext.iterator.constructor
    • esnext.iterator.find

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

@patmmccann

Copy link
Copy Markdown
Collaborator

Import your new types into your adapter using jsdoc and note your test failure

@barecheck

barecheck Bot commented Aug 9, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 91.16%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
modules/advertronicBidAdapter.js70, 76-77, 102

@advertronic

Copy link
Copy Markdown
Contributor Author

@patmmccann Thanks for the review — both points addressed in f5cd2cf:

  • The param types from advertronicBidAdapter.d.ts are now imported into the adapter via jsdoc (AdvertronicBidderParams, used to type isBidRequestValid).
  • The test failure in the all features disabled job is fixed: video handling in the adapter and the video test cases are now gated behind FEATURES.VIDEO. Verified locally in both modes (default build and all-features-disabled).

@patmmccann patmmccann removed the core label Aug 9, 2026
@patmmccann
patmmccann merged commit d43d83d into prebid:master Aug 9, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants