New bid adapter: advertronic - #15475
Conversation
|
Docs PR: prebid/prebid.github.io#6694 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a9cdffd1a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Both suggestions addressed in 3429a65: dropped the explicit content type (auction POST is now a simple request, no preflight) and added the bidder params .d.ts. |
|
Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!
|
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
|
Import your new types into your adapter using jsdoc and note your test failure |
Barecheck - Code coverage reportTotal: 91.16%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
|
@patmmccann Thanks for the review — both points addressed in f5cd2cf:
|
Type of change
Description of change
New bid adapter for Advertronic SSP (banner and video).
Thin adapter built on the ortbConverter library; the endpoint speaks plain OpenRTB 2.x.
Outstream video is rendered by our own renderer (loaded from Advertronic servers) unless the publisher supplies one on the ad unit.
Bid prices are net to the publisher, currency is RUB (documented on the bidder page).
Single iframe user sync; the partner list and frequency capping are handled server-side.
Test parameters in
modules/advertronic.mdconsistently return a static test creative from any location.contact email of the adapter maintainer: info@advertronic.io
official adapter submission
unit tests added (
test/spec/modules/advertronicBidAdapter_spec.js)Docs PR: (link will be added right after it is opened)