Skip to content

Checks nullable bids for next gen custom targeting - #940

Open
mdanylov-sigma wants to merge 1 commit into
masterfrom
feature/939-nextgen-nullable-bids
Open

Checks nullable bids for next gen custom targeting#940
mdanylov-sigma wants to merge 1 commit into
masterfrom
feature/939-nextgen-nullable-bids

Conversation

@mdanylov-sigma

Copy link
Copy Markdown
Collaborator

@postindustria-code postindustria-code left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

# Conflicts:
#	PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/Util.java
@mdanylov-sigma
mdanylov-sigma force-pushed the feature/939-nextgen-nullable-bids branch from 5902819 to 84c2d3d Compare July 15, 2026 20:33
@YuriyVelichkoPI

YuriyVelichkoPI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@mdanylov-sigma please double check if the fix is still needed? The issue was found before cfd753d which introduces the current guard

if(bids == null || bids.isEmpty()) {
    return;
}

If so - let's keep the current version. It's better to have "guards" then code inside if { }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants