Distribute per-bidder page view IDs from ext.prebid to adapters by acsbendi · Pull Request #4576 · prebid/prebid-server

acsbendi · 2025-10-22T08:32:09Z

These changes enable adaptors to use their page view ID sent by Prebid.js.
See prebid/Prebid.js#14051 for details.

github-actions · 2025-10-22T08:33:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a403f9e

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:45:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:157:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:172:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:186:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:195:	sanitizeDevice		100.0%
total:									(statements)		82.9%

github-actions · 2025-11-18T14:35:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2e3081c

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:45:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:157:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:172:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:186:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:195:	sanitizeDevice		100.0%
total:									(statements)		82.9%

github-actions · 2025-11-18T14:44:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 069b5d6

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:45:	MakeRequests		66.7%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:126:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:157:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:172:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:186:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/kobler/kobler.go:195:	sanitizeDevice		100.0%
total:									(statements)		82.9%

SyntaxNode · 2026-05-13T04:49:50Z

 	GlobalPrivacyControlHeader string
 	CurrencyConversions        currency.Conversions
 	PreferredMediaType         openrtb_ext.BidType
+	PageViewId                 string


Fields in this structure need to be passed this way because they are not present in the request body. The PageViewID is in the request body. I understand it needs to be scoped to each bidder, but why can't the bidder access that information within the request?

So, do you recommend removing all the other page view IDs from the bid request and only keeping the one specific to that adapter?

przemkaczmarek · 2026-08-03T14:04:26Z

@acsbendi please change PR title

przemkaczmarek · 2026-08-03T14:22:13Z

This is not an "adapter change" — it is an extension of the exchange protocol with a sample implementation in a single adapter. That completely changes the review perspective.

acsbendi · 2026-08-06T09:17:56Z

@przemkaczmarek What's your suggestion for the title?

github-actions · 2026-08-06T10:44:33Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a08c60b

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:44:	MakeRequests		66.7%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:125:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:156:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:171:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:185:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:194:	sanitizeDevice		100.0%
total:									(statements)		82.9%

przemkaczmarek · 2026-08-06T13:00:02Z

@przemkaczmarek What's your suggestion for the title?

distribute per-bidder page view IDs from ext.prebid to adapters

github-actions · 2026-08-06T13:39:19Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 459eb5c

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:40:	MakeRequests		55.3%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:134:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:165:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:180:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:194:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:203:	sanitizeDevice		100.0%
total:									(statements)		75.0%

github-actions · 2026-08-07T07:36:27Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f31714a

kobler

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:27:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:40:	MakeRequests		55.3%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:134:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:165:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:180:	convertImpCurrency	100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:194:	sanitizeRequest		100.0%
github.com/prebid/prebid-server/v4/adapters/kobler/kobler.go:203:	sanitizeDevice		100.0%
total:									(statements)		75.0%

Page view ID.

a403f9e

acsbendi mentioned this pull request Oct 22, 2025

Various modules: consolidate page view ID logic prebid/Prebid.js#14051

Merged

10 tasks

Merge branch 'upstream-master'

2e3081c

Fixed extra arguments.

069b5d6

acsbendi mentioned this pull request Jan 5, 2026

Feature request: page view ID #4649

Open

SyntaxNode reviewed May 13, 2026

View reviewed changes

przemkaczmarek reviewed Aug 6, 2026

View reviewed changes

Comment thread adapters/kobler/kobler.go

przemkaczmarek reviewed Aug 6, 2026

View reviewed changes

Comment thread adapters/kobler/kobler.go Outdated

Changed Marshal function.

a08c60b

acsbendi changed the title ~~Page view ID.~~ Distribute per-bidder page view IDs from ext.prebid to adapters Aug 6, 2026

Preserve original ext.

459eb5c

Merge branch 'master' into master

f31714a

acsbendi requested review from SyntaxNode and przemkaczmarek August 10, 2026 13:42

Navigation Menu

Uh oh!

Distribute per-bidder page view IDs from ext.prebid to adapters - #4576

Distribute per-bidder page view IDs from ext.prebid to adapters#4576
acsbendi wants to merge 6 commits into
prebid:masterfrom
Essens:master

acsbendi commented Oct 22, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 22, 2025

Uh oh!

github-actions Bot commented Nov 18, 2025

Uh oh!

github-actions Bot commented Nov 18, 2025

Uh oh!

SyntaxNode May 13, 2026

Uh oh!

acsbendi May 13, 2026

Uh oh!

przemkaczmarek commented Aug 3, 2026

Uh oh!

przemkaczmarek commented Aug 3, 2026

Uh oh!

acsbendi commented Aug 6, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

przemkaczmarek commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

acsbendi commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 22, 2025

Code coverage summary

kobler

Uh oh!

github-actions Bot commented Nov 18, 2025

Code coverage summary

kobler

Uh oh!

github-actions Bot commented Nov 18, 2025

Code coverage summary

kobler

Uh oh!

SyntaxNode May 13, 2026

Choose a reason for hiding this comment

Uh oh!

acsbendi May 13, 2026

Choose a reason for hiding this comment

Uh oh!

przemkaczmarek commented Aug 3, 2026

Uh oh!

przemkaczmarek commented Aug 3, 2026

Uh oh!

acsbendi commented Aug 6, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 6, 2026

Code coverage summary

kobler

Uh oh!

przemkaczmarek commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Code coverage summary

kobler

Uh oh!

github-actions Bot commented Aug 7, 2026

Code coverage summary

kobler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

acsbendi commented Oct 22, 2025 •

edited

Loading