Skip to content

New Adapter: Proxistore - #4731

Open
anthonyrichir wants to merge 14 commits into
prebid:masterfrom
proxistore:proxistore-adapter
Open

New Adapter: Proxistore#4731
anthonyrichir wants to merge 14 commits into
prebid:masterfrom
proxistore:proxistore-adapter

Conversation

@anthonyrichir

Copy link
Copy Markdown

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Prebid doc PR

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9d8e84e

proxistore

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:26:	MakeRequests		88.9%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:48:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:93:	getMediaTypeForBid	100.0%
total:										(statements)		97.4%

@bsardo bsardo added the adapter label Mar 31, 2026
@anthonyrichir

Copy link
Copy Markdown
Author

Anyone available for review this PR ?

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 251afbf

proxistore

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:26:	MakeRequests		88.9%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:48:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:93:	getMediaTypeForBid	100.0%
total:										(statements)		97.4%

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 73b9a5d

proxistore

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:26:	MakeRequests		88.9%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:48:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:93:	getMediaTypeForBid	100.0%
total:										(statements)		97.4%

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 97c93f0

proxistore

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:26:	MakeRequests		88.9%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:48:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:93:	getMediaTypeForBid	100.0%
total:										(statements)		97.4%

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, df79322

proxistore

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:26:	MakeRequests		88.9%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:48:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:93:	getMediaTypeForBid	100.0%
total:										(statements)		97.4%

Comment thread static/bidder-info/proxistore.yaml
Comment thread adapters/proxistore/params_test.go
anthonyrichir and others added 2 commits June 24, 2026 09:51
- Add endpointCompression: gzip to reduce S2S traffic
- Use require/assert (testify) in params_test instead of t.Fatalf/t.Errorf
@anthonyrichir
anthonyrichir requested a review from linux019 June 24, 2026 09:50
linux019
linux019 previously approved these changes Jun 24, 2026
@anthonyrichir

Copy link
Copy Markdown
Author

@bsardo Anyone else for second review ?

@anthonyrichir

Copy link
Copy Markdown
Author

@linux019 is it possible to get someone else to do the second review ?

@github-actions

Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 1b078b6

proxistore

Refer here for heat map coverage report

github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:26:	MakeRequests		88.9%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:48:	MakeBids		100.0%
github.com/prebid/prebid-server/v4/adapters/proxistore/proxistore.go:93:	getMediaTypeForBid	100.0%
total:										(statements)		97.4%

Comment thread adapters/proxistore/proxistore.go Outdated
@postindustria-code

Copy link
Copy Markdown
Contributor

Sent the verification email to support@proxistore.com from marina.lebedeva@postindustria.com
I'm waiting for a response for PR approve

@postindustria-code

Copy link
Copy Markdown
Contributor

Endpoint reachability checkPOST https://api.proxistore.com/v3/rtb/openrtb

$ curl -i --location --request POST "https://api.proxistore.com/v3/rtb/openrtb" \
    -H "Content-Type: application/json" -H "Accept: application/json" \
    -d '{"id":"smoke-test","imp":[{"id":"1","banner":{"format":[{"w":300,"h":250}]},"ext":{"bidder":{"website":"example.com","language":"fr"}}}],"site":{"doma
in":"example.com","page":"https://example.com"},"test":1}'

HTTP/2 204
date: Wed, 22 Jul 2026 09:23:57 GMT
vary: Origin
x-content-type-options: nosniff
cache-control: no-cache, no-store, max-age=0, must-revalidate
strict-transport-security: max-age=31536000 ; includeSubDomains
x-frame-options: DENY

Endpoint is reachable over HTTPS/2 and correctly returns 204 No Content (no bid) for a well-formed OpenRTB request — no real bid returned, as expected. (An empty {} body returns 400.)

@postindustria-code

Copy link
Copy Markdown
Contributor

Sent the verification email to support@proxistore.com from marina.lebedeva@postindustria.com I'm waiting for a response for PR approve

image

The answer has been received.

@anthonyrichir

Copy link
Copy Markdown
Author

@postindustria-code Sorry — I accidentally dismissed your approval (along with a stale review) on July 23rd. Your endpoint verification and the email confirmation from support@proxistore.com are still valid and documented above. Could you please re-approve when you have a moment? The PR currently sits at 1 approval because of my mistake. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants