Flipp: Use customData maxWidth/maxHeight for bid dimensions - #4866
Open
mike-lei wants to merge 2 commits into
Open
Flipp: Use customData maxWidth/maxHeight for bid dimensions#4866mike-lei wants to merge 2 commits into
mike-lei wants to merge 2 commits into
Conversation
Some publishers build their ad container from the width/height in our bid response. For Rich Media units the response returned the wrong size (e.g. 300x250 into a 320x480 slot), cutting the unit off. Prefer customData maxWidth/maxHeight for bid.W/bid.H when present and non-zero, falling back to existing behavior otherwise. Also fix the contents guard (|| -> &&) so a partial response cannot panic. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Code coverage summaryNote:
flippRefer here for heat map coverage report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxWidth/maxHeightfromcustomDatawhen setting bidW/Hdecision.Contents(||→&&) that could panic whenContentsis emptycdn-gateflipp.flippback.comtoads-flipp.comAdds exemplary test
simple-banner-native-rich-media.json.