Adding support for new fetchers 2.0 Account fetchers - #4895
Open
karwaankit32 wants to merge 4 commits into
Open
Conversation
karwaankit32
commented
Aug 3, 2026
| // contributes nothing to bulk cache preloading and reports no error. Accounts still | ||
| // load lazily on demand via FetchAccount. | ||
| func (fetcher *HttpFetcher) FetchAllAccounts(ctx context.Context) (map[string]json.RawMessage, []error) { | ||
| logger.Warnf("http_fetcher: bulk account preload is not supported by the by-id HTTP endpoint; accounts will load lazily on demand") |
Contributor
Author
There was a problem hiding this comment.
Will implement this in a follow up PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for new fetchers 2.0 Account fetchers
Design - #4860
Validation Summary
Validation was performed in a non-production Kubernetes canary environment using both filesystem-backed and HTTP-backed account sources.
Design Reference
#4860
Fetchers 2.0 caches the final typed
*config.Accountinstead of caching raw JSON bytes. This avoids repeated account defaults merge, JSON unmarshal, DSA unpacking, derived GDPR map creation, and IP masking defaults on account cache hits.Metrics Used
prebid_server_cachekit_cache_result{result="miss",subsystem="account"}prebid_server_cachekit_cache_result{result="hit",subsystem="account"}prebid_server_cachekit_cache_result{result="negative",subsystem="account"}prebid_server_cachekit_backend_fetch{result="ok",subsystem="account"}prebid_server_cachekit_backend_fetch{result="notfound",subsystem="account"}prebid_server_cachekit_backend_fetch{result="error",subsystem="account"}prebid_server_account_cache_performance{cache_result="hit/miss"}Compatibility and Filesystem Source Tests
/cookie_syncaccounts.v2_enabled=false/cookie_synclru,refresh=ttl, negative offbackend ok +1,miss +1,hit +1serve_stale=falsenotfound +2, no negative metricrefresh=nonecache.type=none, negative offcache.type=none, negative onserve_stale=truerefresh=preloadmax_entries=1HTTP Source Tests
refresh=ttlrefresh=preload, HTTP source onlyEndpoint Coverage
/cookie_sync/cookie_sync/openrtb2/auctionseatbid/openrtb2/auctionseatbidStress and Thundering Herd Tests
MOCK_SLOW_DELTA=1, backend ok +1MOCK_ABSENT_DELTA=1, negative +997serve_stale=trueNotes
serve_stale=trueprebid_server_account_cache_performancestayed zero