Fix: Decode double-encoded HTML entities in script/style attributes - #371
Closed
OlenaPostindustria wants to merge 3 commits into
Closed
Fix: Decode double-encoded HTML entities in script/style attributes#371OlenaPostindustria wants to merge 3 commits into
script/style attributes#371OlenaPostindustria wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PUC 1.18.0 addressed Postscribe’s mishandling of single-quoted HTML attributes by re-serializing the
admthroughDOMParserbefore rendering. The HTML serializer correctly escapes&as&, within attribute values. However, this exposed a latent issue in Postscribe that caused impression callbacks loaded via<script src>to break.Fix
Decode entities at the exact point postscribe diverges from browser behavior, using
postscribe's supported
beforeWriteTokenhook:tok.src(postscribe copiesattrs.src=>tok.srcbefore the hook runs, andassigns
el.src = tok.srcwhen building the element).innerHTMLwhere entities must stay encoded for the browser to decode.
DOMParser)instead of string replacement, so it matches browser attribute-decoding rules
exactly:
&=>&, while semicolon-less legacy references common in querystrings (
¬ify=,©=) stay literal, as they would in a real browser.Also hardens
normalizeMarkup: a marker element forces the parser into body mode soleading comments (e.g. Prebid's
<!--Creative served by ...-->) and head-boundelements are preserved in order instead of being dropped or scattered into
<head>.