Unicorn bid adapter: document ad slot position signals - #6674
Open
harufujimoto wants to merge 4 commits into
Open
Unicorn bid adapter: document ad slot position signals#6674harufujimoto wants to merge 4 commits into
harufujimoto wants to merge 4 commits into
Conversation
Docs for the Unicorn RTD Provider submodule added in prebid/Prebid.js#15379.
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jul 23, 2026
muuki88
requested changes
Aug 11, 2026
muuki88
left a comment
muuki88
left a comment
Contributor
There was a problem hiding this comment.
Minor nitpick, then this is good to go
Comment on lines
+17
to
+19
| Module Name: Unicorn Rtd Provider | ||
| Module Type: Rtd Provider | ||
| Maintainer: <service+prebid.js@bulbit.jp> |
Contributor
There was a problem hiding this comment.
Suggested change
| Module Name: Unicorn Rtd Provider | |
| Module Type: Rtd Provider | |
| Maintainer: <service+prebid.js@bulbit.jp> | |
| Maintainer: <service+prebid.js@bulbit.jp> |
meta data already cover this
The RTD provider was removed upstream (prebid/Prebid.js#15379) — the position/geometry/viewability measurement now runs inline in the bid adapter. This makes the standalone RTD module doc obsolete (it also described a stale wire format: ortb2Imp.ext.data.adslot / imp.ext.adslot / banner.pos=2). Remove dev-docs/modules/unicornRtdProvider.md and instead document the current, adapter-native behavior in the bidder doc: imp.banner.pos (1/3) and imp.ext.unicorn { ver, ratio, fixed, sticky, w, h, x, y }, plus the slot element resolution order. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
harufujimoto
changed the title
Editing the file made CI lint the whole doc, surfacing pre-existing violations: MD001 (first heading must be h2 given the front-matter title, not h3) and MD060 (table must use the compact pipe style). Reformat the heading levels and the bid-params table to match the repo's markdownlint config; verified locally with markdownlint-cli2 (0 issues). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
The table was fine 😁 Claude, try again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for the Unicorn RTD Provider submodule.
Companion to the Prebid.js code PR: prebid/Prebid.js#15379
Adds
dev-docs/modules/unicornRtdProvider.mddescribing:ortb2Imp.banner.pos,ortb2Imp.ext.data.adslot);realTimeData.dataProviders, noparams);The module is maintained by service+prebid.js@bulbit.jp.