Repository navigation
perf(ci): prebake pinned Rust toolchain - #228
Merged
Merged
Conversation
|
New pull request. Leaping into action... |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bnjoroge1
added a commit
that referenced
this pull request
Sep 10, 2026
Three independent regressions had CI red for five days and the golden bake dead for a month. 1. f84e3c7 deleted SMOLVM_MAX_IMAGE_BYTES from both bake steps while only editing comments. The pinned runner-large base unpacks to ~17 GiB via docker save, over smolvm's 8 GiB default local-archive cap, so every build-golden attempt died in smolvm create before extracting a byte. Restored on both arch steps. 2. 7f18e8a repointed the aarch64 golden from macos-14 to [self-hosted, macOS, ARM64]. No runner has ever carried those labels, so the job was never dispatched and GitHub cancelled it at the 24h ceiling on every run since. Back to hosted Apple Silicon with the TSI net backend the hosted path requires. 3. #228 removed the toolchain and lld installs from ci.yml expecting a prebaked golden, but 1 and 2 meant no such golden was ever built. Jobs land on a runner with cargo only under /root/.cargo/bin and fail with 'cargo: command not found'. Restored the setup steps, ordered before rust-cache so its rustc -vV probe succeeds. Also adds timeout-minutes to both golden jobs so an undispatched job costs minutes instead of a day, and scopes the x86_64 bake to smolvm-host.
Bnjoroge1
added a commit
that referenced
this pull request
Sep 13, 2026
Bnjoroge1
added a commit
that referenced
this pull request
Sep 13, 2026
Three independent regressions had CI red for five days and the golden bake dead for a month. 1. f84e3c7 deleted SMOLVM_MAX_IMAGE_BYTES from both bake steps while only editing comments. The pinned runner-large base unpacks to ~17 GiB via docker save, over smolvm's 8 GiB default local-archive cap, so every build-golden attempt died in smolvm create before extracting a byte. Restored on both arch steps. 2. 7f18e8a repointed the aarch64 golden from macos-14 to [self-hosted, macOS, ARM64]. No runner has ever carried those labels, so the job was never dispatched and GitHub cancelled it at the 24h ceiling on every run since. Back to hosted Apple Silicon with the TSI net backend the hosted path requires. 3. #228 removed the toolchain and lld installs from ci.yml expecting a prebaked golden, but 1 and 2 meant no such golden was ever built. Jobs land on a runner with cargo only under /root/.cargo/bin and fail with 'cargo: command not found'. Restored the setup steps, ordered before rust-cache so its rustc -vV probe succeeds. Also adds timeout-minutes to both golden jobs so an undispatched job costs minutes instead of a day, and scopes the x86_64 bake to smolvm-host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bakes the repository-pinned Rust 1.97 toolchain into stock and official runner goldens, verifies the exact toolchain plus rustfmt/clippy, removes redundant CI rustup and apt installs, and enables Cargo caching for property jobs. Also refreshes the stale dtolnay action pin required by zizmor.
Summary by cubic
Prebakes the repository-pinned Rust 1.97 toolchain into stock Ubuntu and official runner goldens so CI jobs no longer install it on every run.
rustc,rustfmt, andclippyviarustupinstead of only thecargobinary.rust_toolchain_versioninversions.toml, so bumping it invalidates the golden fingerprint.dtolnay/rust-toolchainaction pin required by zizmor.Written for commit 341cd65. Summary will update on new commits.