Skip to content

fix(parser): canonicalize $/ prefix in reusable workflow refs - #246

Merged
Bnjoroge1 merged 1 commit into
mainfrom
Bnjoroge/canonicalize-reusable-workflow-alias
Sep 11, 2026
Merged

Bnjoroge1 merged 1 commit into
mainfrom
Bnjoroge/canonicalize-reusable-workflow-alias

Conversation

@Bnjoroge1

@Bnjoroge1 Bnjoroge1 commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Canonicalizes both ./ and $/ local-workflow reference prefixes in normalize_reusable_path.
  • Prevents workflows referencing the same reusable workflow via ./ and $/ from creating duplicate entries in the call tree / unique_workflows set and prematurely exceeding the 50-workflow limit.
  • Also canonicalizes $/ in format_reusable_workflow_ref in preloop-runner-server for consistent OIDC claims.
  • Added unit test reusable_workflow_dollar_slash_alias_canonicalized.

Summary by cubic

Canonicalizes $/ in reusable workflow references so ./ and $/ pointing to the same file resolve to one workflow. This stops duplicate call-tree entries that could prematurely exceed the 50-workflow limit.

Bug Fixes

  • Treats ./ and $/ as the same local path in normalize_reusable_path.
  • Formats $/ refs consistently in format_reusable_workflow_ref for OIDC claims.
  • Adds a test mixing both prefixes across 50 unique workflows.

Written for commit f8f3f25. Summary will update on new commits.

Review in cubic

@pullfrog

pullfrog Bot commented Sep 11, 2026

Copy link
Copy Markdown

New pull request. Leaping into action...

Pullfrog  | View workflow run | via Pullfrog | 𝕏

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 76b349fb-3f38-4677-8ccb-ac3515c5ff47

📥 Commits

Reviewing files that changed from the base of the PR and between ecdfad5 and f8f3f25.

📒 Files selected for processing (3)
  • crates/preloop-gha-parser/src/expand.rs
  • crates/preloop-gha-parser/src/lib_tests.rs
  • crates/preloop-runner-server/src/broker.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Bnjoroge1
Bnjoroge1 merged commit f8f3f25 into main Sep 11, 2026
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant