restore strict UTF-8 validation in text decoding#25
Merged
Conversation
SebastienGllmt
force-pushed
the
restore-utf8-validation
branch
from
f46681f to
6ca445a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ed40f20 changed the utf8 parsing from from strict
String::from_utf8(bytes)?tofrom_utf8_lossyRFC 8949 §3.1 requires major-type-3 payloads to be valid UTF-8, so this is a regression
This is a breaking change from 3.0.0 (return to v2 behavior)
This matches the behavior of other crates (serde_cbor, ciborium, cbor4ii) which all similarly error (like this PR)
Note: particularly important for cddl-codegen, as this regression broke round-trip serialization
Side-note: separately,
Serializer::write_text_sz()now reports a chunk split falling inside a UTF-8 character asError::InvalidTextErrorinstead of the incorrectError::InvalidLenPassed