Use Vec for Object and IObject, replacing ObjectKey#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
ObjectKeydoesn't support every cbor type (not even negative ints)Instead of extending
ObjectKeyto support more types (it could be extended to support basically everything but floats), I think it makes more sense to justValueas they "key" forObject.Switching from
BTreeMap→Vecmeans we no longer have the sorting issue for float keys (so we can support all keys and not just someObjectKeysubset), and the fact thatVeccan have duplicate keys is actually arguably correct because CBOR supports duplicate keys in mapsNote: this doesn't "drop" support for BTreeMap. If you don't want duplicate keys, you can still just do
BTreeMap::deserialize. It will just silently use the last-wins first rule for map (which is what people tend to expect with maps anyways, even if cbor doesn't enforce this)