perf: remove core metric fallback truthiness

CHANGELOG.md

@@ -17,6 +17,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
 - fix: Correct content type exported for cluster and worker mode.
 - perf: Remove truthy conditionals from default metric collectors
 - fix: Preserve zero-valued Counter exemplars
+- perf: Remove object and array fallback truthiness from core metric paths
 
 ### Added
 

lib/counter.js

@@ -124,14 +124,14 @@ class Counter extends Metric {
 	}
 
 	labels(...args) {
-		const labels = getLabels(this.labelNames, args) || {};
+		const labels = getLabels(this.labelNames, args) ?? {};
 		return {
 			inc: this.inc.bind(this, labels),
 		};
 	}
 
 	remove(...args) {
-		const labels = getLabels(this.labelNames, args) || {};
+		const labels = getLabels(this.labelNames, args) ?? {};
 		this.store.validate(labels); //TODO: this isn't really necessary is it?
 		this.store.remove(labels);
 	}

lib/histogram.js

@@ -82,15 +82,15 @@ class Histogram extends Metric {
 	 * @returns {void}
 	 */
 	observeWithoutExemplar(labels, value) {
-		observe(this, labels === 0 ? 0 : labels || {}, value);
+		observe(this, labels === 0 ? 0 : (labels ?? {}), value);
 	}
 
 	observeWithExemplar({
 		labels = this.defaultLabels,
 		value,
 		exemplarLabels = this.defaultExemplarLabelSet,
 	} = {}) {
-		observe(this, labels === 0 ? 0 : labels || {}, value);
+		observe(this, labels === 0 ? 0 : (labels ?? {}), value);
 		this.updateExemplar(labels, value, exemplarLabels);
 	}
 

lib/metrics/helpers/processMetricsHelpers.js

@@ -36,7 +36,7 @@ function aggregateByObjectName(list) {
 function updateMetrics(gauge, data, labels) {
 	gauge.reset();
 	for (const key in data) {
-		gauge.set(Object.assign({ type: key }, labels || {}), data[key]);
+		gauge.set(Object.assign({ type: key }, labels ?? {}), data[key]);
 	}
 }
 

lib/registry.js

@@ -78,7 +78,7 @@ class Registry {
 		const isOpenMetrics =
 			this.contentType === Registry.OPENMETRICS_CONTENT_TYPE;
 
-		for (const val of metric.values || []) {
+		for (const val of metric.values ?? []) {
 			const { metricName = name, labels = {}, sharedLabels } = val;
 			const seriesName =
 				isOpenMetrics && metric.type === 'counter'

lib/summary.js

@@ -57,7 +57,7 @@ class Summary extends Metric {
 	 * @returns {void}
 	 */
 	observe(labels, value) {
-		observe.call(this, labels === 0 ? 0 : labels || {})(value);
+		observe.call(this, labels === 0 ? 0 : (labels ?? {}))(value);
 	}
 
 	async get() {

lib/util.js

@@ -56,7 +56,7 @@ exports.setValue = function setValue(hashMap, value, labels) {
 	const hash = hashObject(labels);
 	hashMap.set(hash, {
 		value: typeof value === 'number' ? value : 0,
-		labels: labels || {},
+		labels: labels ?? {},
 	});
 	return hashMap;
 };