fix: clear registry on config reload to pick up new bucket settings - #747
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: clear registry on config reload to pick up new bucket settings#747AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
When the mapping configuration is reloaded via SIGHUP or lifecycle API, the MetricMapper is reinitialized but the Registry retains cached histogram/summary vectors with the old bucket or quantile settings. This causes the exporter to continue using stale configuration. Add a Reset() method to the Registry interface and call it after successful config reload to force re-registration of metrics with the new bucket/quantile configuration. Fixes prometheus#471 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Contributor
|
I dont think this will be needed anymore since:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471
When the mapping configuration is reloaded via SIGHUP or lifecycle API, the MetricMapper is reinitialized but the Registry retains cached histogram/summary vectors with the old bucket or quantile settings. This causes the exporter to continue using stale configuration after reload.
Changes:
Root cause: The Registry caches prometheus.HistogramVec and prometheus.SummaryVec objects. These are created once with the bucket/quantile configuration at the time of first use. When the mapping config is reloaded with different bucket settings, the old vectors are still returned for subsequent metric lookups.