Repository navigation
Move tests to PHPUnit 10+ - #38
Merged
Merged
Conversation
codeception-psalm-module 0.14.0 skips scenarios by throwing PHPUnit\Framework\SkippedTestError, which PHPUnit 10 removed; the next module release uses Assert::markTestSkipped() instead. Also drop the acceptance helper's unused imports, one of which was that PHPUnit 9 class. Claude-Session: https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW
danog
marked this pull request as ready for review
October 20, 2026 09:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests are pinned to PHPUnit 9, and codeception-psalm-module 0.14.0 never counts passing steps as assertions.
Before (module 0.14.0):
After (PHPUnit 10.5, 11.5 and 13, module branch danog/codeception-psalm-module@phpunit-10):
Draft until that module change is released;
^0.14.1assumes it is tagged 0.14.1.https://claude.ai/code/session_01WNSb29tptiTQoc44Tk7XZW