Update UImGui to Dear ImGui 1.92.9 - #94
Conversation
|
Final antivirus validation completed.
Combined with the green native matrix, binding CI, package CI, 7/7 native tests, and 19/19 Unity tests, the release candidate meets the merge-readiness criteria. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d45d88fe6b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| implot3d ImPlot3D.NET cimplot3d | ||
| imnodes ImNodes.NET cimnodes | ||
| imnodes_r ImNodesR.NET cimnodes_r | ||
| imguizmo ImGuizmo.NET cimguizmo |
There was a problem hiding this comment.
Add ARM64 DLLs to checksum verification
The artifact-matrix step accepts eight win-arm64 DLLs, but WINDOWS_SHA256SUMS contains only the 16 x86/x64 binaries. GNU sha256sum --help defines --check as “read checksums from the FILEs and check them,” so this command succeeds even if any committed ARM64 DLL is replaced or corrupted. Include the ARM64 artifacts in the manifest, and preferably validate that every Windows native DLL has exactly one entry. KKUT.mdL9-L9
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Just flagging that this file has no meta file so currently causes a (non-blocking) error in Unity. Not sure if the intention is to delete this file before merging the PR.
Summary
ImDrawData.CmdListsAPIsync-imgui.ps1pipelineWhy
This addresses the generic ESET detection reported in #91. The affected files are unsigned, low-prevalence native extension DLLs, and the audit found no suspicious imports or behavior. The rebuild/hardening is intended to reduce reputation-based false positives and make every artifact traceable to one source revision. The package is still unsigned because the project does not currently have an Authenticode code-signing certificate.
Verification
Pluginstree: no threats; the four VirusTotal/Microsoft-flagged files were also re-scanned individually with engine1.1.26060.3008and definitions1.455.392.0, all clean.metasidecars, removed API usage, and all Windows SHA-256 checks passed18.2.18.0/ update20260728reported all seven files asundetected; residual minority results are generic ML/heuristic labels and are documented per fileThe release candidate has completed the planned checks and is ready for review and merge. No release tag is created by this PR.