Colors missing when opening Octo buffers directly

[williambdean]

The harpoon plugin allows you to pin files in a picker, which persists across Neovim restarts.

I've noticed that after a restart, opening octo buffers through harpoon - or even just with :edit octo://... some syntax highlighting is missing, e.g., the diff bar and the assignees aren't coloured.

If I open the Octo picker with the partially coloured PR open and close it again, everything is coloured correctly.
So, I assume opening Octo - not just loading it via Lazy - triggers some additional functionality that I'm not calling when opening an Octo PR without going through Octo itself.

Does anyone have experience using octo with harpoon or have some pointers how I could address this?

Originally posted by @paulhdk in #649

[williambdean]

Don't think this is limited to harpoon.

using :e <octo-buffer-uri> from fresh start has the same issue

For instance, octo://pwntester/octo.nvim/issue/771

[paulhdk]

@wd60622 in #649:

I experience this as well. I am thinking the highlight groups arent initialized or something.
Have you played around with it more and discovered anything?

I haven't. But I want to give it another go when I have more time. This could make a nice first contribution from my side, I hope!

[williambdean]

It'd be a great contribution, indeed!
Well toy around with it a bit. If you do have any information, comment it here in this thread. And it will get solved eventually 😄

[GuillaumeLagrange]

Are you guys lazy loading Octo in any way ?

[paulhdk]

Are you guys lazy loading Octo in any way ?

Yes. I have lazy = true and load Octo through the mappings I've set.

[GuillaumeLagrange]

Do you reproduce the issue without lazy loading ?

Could be due to octo not being properly loaded in when doing simple :e path/to/octo/buffer since the "normal" way of doing so includes a lazy load trigger

[williambdean]

I have lazy loading as well. But did try without which still had the same effect

[williambdean]

It seems like the colors just aren't setup before the buffer is opened / on the first open with the buffer autocmds.

-- Call this first
require "octo.ui.colors".setup()
--- Then open the buffer with the uri

Would have to have this in one of the autocmds as well

octo.nvim/lua/octo/commands.lua

Lines 867 to 870 in 8217c8d

	if not _G.octo_colors_loaded then
	colors.setup()
	_G.octo_colors_loaded = true
	end

Would you be able to give this a try and see if it fixes the issues? @paulhdk

[vimscientist69]

It seems like the colors just aren't setup before the buffer is opened / on the first open with the buffer autocmds.

-- Call this first
require "octo.ui.colors".setup()
--- Then open the buffer with the uri
Would have to have this in one of the autocmds as well

octo.nvim/lua/octo/commands.lua

Lines 867 to 870 in 8217c8d

if not _G.octo_colors_loaded then
colors.setup()
_G.octo_colors_loaded = true
end
Would you be able to give this a try and see if it fixes the issues? @paulhdk

For me when adding an octo pull request tab to harpoon with harpoon add, when I opened it by going to that pinned item, it was an empty buffer. It is because when executing harpoon add, it does not escape the // in octo://. When I escaped it the //, it worked.

[williambdean]

Do you manually do that edit or do you provide a hook with harpoon? @vimscientist69

[vimscientist69]

Do you manually do that edit or do you provide a hook with harpoon? @vimscientist69

Just created a pull request.

ThePrimeagen/harpoon#665

[vimscientist69]

@williambdean , not sure if the error problem you encounter is the exact as mine (fixed in the pull request). Just thought it would be relevant to share.

If you want to use it without waiting for the PR to get merged, use my fork: https://github.com/vimscientist69/harpoon

[paulhdk]

It seems like the colors just aren't setup before the buffer is opened / on the first open with the buffer autocmds.

-- Call this first
require "octo.ui.colors".setup()
--- Then open the buffer with the uri

Would have to have this in one of the autocmds as well

octo.nvim/lua/octo/commands.lua

Lines 867 to 870 in 8217c8d
if not _G.octo_colors_loaded then
colors.setup()
_G.octo_colors_loaded = true
end

Would you be able to give this a try and see if it fixes the issues? @paulhdk

Hm. I'm not able to reproduce the problem right now.

When I try to access a PR after a nvim reboot, it doesn't load anything (probably because the Octo plugin isn't loaded yet?), and when I load Octo, e.g., by opening the picker, and then try to access a PR again, it works fine, colours and all.

[vimscientist69]

It seems like the colors just aren't setup before the buffer is opened / on the first open with the buffer autocmds.
-- Call this first
require "octo.ui.colors".setup()
--- Then open the buffer with the uri
Would have to have this in one of the autocmds as well
octo.nvim/lua/octo/commands.lua
Lines 867 to 870 in 8217c8d
if not _G.octo_colors_loaded then
colors.setup()
_G.octo_colors_loaded = true
end
Would you be able to give this a try and see if it fixes the issues? @paulhdk

Hm. I'm not able to reproduce the problem right now.

When I try to access a PR after a nvim reboot, it doesn't load anything (probably because the Octo plugin isn't loaded yet?), and when I load Octo, e.g., by opening the picker, and then try to access a PR again, it works fine, colours and all.

That happens to me as well. To solve this, execute Octo pr if you are checked out on that PR branch. If not, open the PR with Octo pr list.

I have a mapping <leader>opo that executes Octo pr to open the current pr when I close and re-open neovim. I interpret it as "octo pr open".