Skip to content

feat(pr): add <localleader>ve to start/resume a review - #1569

Open
Danthewaann wants to merge 1 commit into
pwntester:masterfrom
Danthewaann:add-review-mapping
Open

Danthewaann wants to merge 1 commit into
pwntester:masterfrom
Danthewaann:add-review-mapping

Conversation

@Danthewaann

Copy link
Copy Markdown
Contributor

Describe what this PR does / why we need it

Add a new <localleader>ve bind that starts/resumes a review for the given pull request. The functionality to do this was already there, it just wasn't wired up. I'd argue it's better to use this over the existing start review (<localleader>vs) and resume review (<localleader>vr) mappings, but I won't remove existing mappings since people likely depend on them.

Does this pull request fix one issue?

NONE

Describe how you did it

Add new review mapping alongside review_start and review_resume

Describe how to verify it

Open a PR with Octo pr and then do <localleader>ve and it will create a review if one doesn't exist, or it will resume an existing review.

Checklist

  • Passing tests and linting standards
  • Documentation updates in README.md and doc/octo.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant