Repository navigation
feat(pr): add <localleader>ve to start/resume a review - #1569
Open
Danthewaann wants to merge 1 commit into
Open
Danthewaann wants to merge 1 commit into
Danthewaann wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Add a new
<localleader>vebind that starts/resumes a review for the given pull request. The functionality to do this was already there, it just wasn't wired up. I'd argue it's better to use this over the existing start review (<localleader>vs) and resume review (<localleader>vr) mappings, but I won't remove existing mappings since people likely depend on them.Does this pull request fix one issue?
NONE
Describe how you did it
Add new
reviewmapping alongsidereview_startandreview_resumeDescribe how to verify it
Open a PR with
Octo prand then do<localleader>veand it will create a review if one doesn't exist, or it will resume an existing review.Checklist