Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fixes a crash in
generate_position2line_mapwhen a diff hunk header does not include the line count for a single-line side (e.g.@@ -1 +1,2 @@). Without the fix you get crashes<C-j>/preview navigation in:Octo pr list.Does this pull request fix one issue?
Fixes #1517
Describe how you did it
Widened the hunk-header regex to accept a missing
,<count>on either side.Describe how to verify it
kheiner#1 reproduces the crash: a one-line addition to
.gitignore(which already had exactly 1 line) produces the diff hunk@@ -1 +1,2 @@and a review comment on it creates a thread with that diffHunk. Opening it with:Octo pr edit 1 kheiner/octo.nvim:Special notes for reviews
Checklist