ROB: Clarify CMYK comment and detect image format from Pillow instead of guessing#3902
Open
BiswasNehaa wants to merge 2 commits into
Open
ROB: Clarify CMYK comment and detect image format from Pillow instead of guessing#3902BiswasNehaa wants to merge 2 commits into
BiswasNehaa wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3902 +/- ##
==========================================
- Coverage 97.86% 97.84% -0.02%
==========================================
Files 57 57
Lines 10738 10740 +2
Branches 2006 2006
==========================================
Hits 10509 10509
- Misses 127 129 +2
Partials 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
6f2f50c to
81c4851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers two of three items in #3869 (CMYK comment + LZW/ASCII85 logic ). Skipped the ICC one.
CMYK: The old comment there pointed to a closed pair with no information. Pillow only got Native CMYK Palette support in v10.1.0, pypdf supports back to 8.0 .0 so the work around stays.
LZW/ASCII85: switched to opening the image first and trusting Pillow's actual detected format, instead of guessing from the filter type ...this is what j-t-1 suggested in the issue thread. Kept the old guess as a fallback for when Pillow can't read it at all.
tested: ran the image test suite, same pass rate as before my change; checked the two real fixture PDFs that hit this code give identical output before/after.
Used Claude to help investigate the Pillow version history and verify the diff.