Repository navigation
[d3d10] fix d3d10core crashing every d3d10 game - #83
Open
The412Banner wants to merge 1 commit into
Open
The412Banner wants to merge 1 commit into
The412Banner wants to merge 1 commit into
Conversation
d3d10core was calling D3D11CoreCreateDevice with the newer 10 argument version, but sarek's d3d11.dll still exports the old 6 argument one. The device ended up in the wrong spot, so every d3d10 game got a null device and crashed right away. Go back to the 6 argument call and link d3d10core against sarek's own d3d11 again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, every D3D10 game crashes on start with Sarek 1.13.0 and 1.14.0.
Since #41, d3d10core calls
D3D11CoreCreateDevicewith the newer 10 argument version, but Sarek's d3d11.dll still exports the old 6 argument one. So the device lands in the wrong spot, d3d10core gets back a null device and crashes on the next line.This puts the call back to the 6 argument version and links d3d10core against Sarek's own d3d11 again (the toolchain's libd3d11.a has the 10 argument one, which is why the 32-bit build needs this).
We've been shipping a patched 1.13.0 in Bannerlator and D3D10 games work again with it, everything else unchanged. If you'd rather update d3d11's export to the 10 argument version instead, that works too.
Thanks for keeping Sarek going!