Clean up dtypes for metadata fields (#1499) - #1499
Merged
Merged
Conversation
|
@ryanzhang22 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113458168. |
meta-codesync
Bot
changed the title
ryanzhang22
added a commit
to ryanzhang22/kineto
that referenced
this pull request
Jul 27, 2026
Summary: Update a bunch of fields from int64_t to uint64_t: - Generic: kPythonParentId - Device properties: kId, kTotalGlobalMem, kSharedMemPerBlock, kSharedMemPerBlockOptin, kSharedMemPerMultiprocessor, kMaxSharedMemoryPerMultiProcessor - CUDA: kAllocatedSharedMemPerBlock, kBytes, kCbid, kChannel, kContext, kCorrelation, kEventId, kFromContext, kFromDevice, kGraphId, kGraphNodeId, kInContext, kInDevice, kQueued, kRegistersPerThread, kToContext, kToDevice, kWaitOnCudaEventId - ROCm: kBytes, kCid, kCorrelation, kHsaQueue, kSharedMemory, kStream Previously, for simplicity, we represented all of these as `int64_t`, and just called static cast to move the fields that are actually produced as `uint64_t` to `int64_t`. This was fine for JSON write, and the unsigned -> signed cast is safe, but the Perfetto logger represents many of these fields as unsigned. I'd like to avoid the unnecessary unsigned -> signed -> unsigned roundtrip and we recently added uint64_t as a TypedValue -- so we can accurately represent this now. Differential Revision: D113458168
ryanzhang22
force-pushed
the
export-D113458168
branch
from
July 27, 2026 17:32
94e2b9b to
cdd0ef0
Compare
Summary: Update a bunch of fields from int64_t to uint64_t: - Generic: kPythonParentId - Device properties: kId, kTotalGlobalMem, kSharedMemPerBlock, kSharedMemPerBlockOptin, kSharedMemPerMultiprocessor, kMaxSharedMemoryPerMultiProcessor - CUDA: kAllocatedSharedMemPerBlock, kBytes, kCbid, kChannel, kContext, kCorrelation, kEventId, kFromContext, kFromDevice, kGraphId, kGraphNodeId, kInContext, kInDevice, kQueued, kRegistersPerThread, kToContext, kToDevice, kWaitOnCudaEventId - ROCm: kBytes, kCid, kCorrelation, kHsaQueue, kSharedMemory, kStream Previously, for simplicity, we represented all of these as `int64_t`, and just called static cast to move the fields that are actually produced as `uint64_t` to `int64_t`. This was fine for JSON write, and the unsigned -> signed cast is safe, but the Perfetto logger represents many of these fields as unsigned. I'd like to avoid the unnecessary unsigned -> signed -> unsigned roundtrip and we recently added uint64_t as a TypedValue -- so we can accurately represent this now. All of the changes are used by Kineto only, so they should be safe. `kPythonParentId` is not used on the profiler side yet, so no compat issue there. Reviewed By: scotts Differential Revision: D113458168
ryanzhang22
force-pushed
the
export-D113458168
branch
from
July 29, 2026 17:23
cdd0ef0 to
4c6c02f
Compare
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 30, 2026
Includes the following commits: - Clean up dtypes for metadata fields (pytorch/kineto#1499) 6f446fe - [xpupti] Fix Windows build support for xpupti tests and multi-config generators. (pytorch/kineto#1394) 9e826ca - Test ConfigLoader on-demand daemon poll ingress (pytorch/kineto#1504) 7674d28 - Remove comment about documentation (pytorch/kineto#1503) eeb3db9 - Remove HTA from README (pytorch/kineto#1502) 46b1c63 - Catch config-update exceptions so the poll thread can't crash the process (pytorch/kineto#1498) be334e1 - Drop EventProfiler config kind from ConfigLoader (pytorch/kineto#1496) e7c97a6 - Remove event-only config surface from Config (pytorch/kineto#1495) a3a0566 - Remove dead event profiler: runtime, CUPTI backends, build wiring (pytorch/kineto#1494) 36c2e05 - Decompose libkineto_defs.bzl source lists into atoms (pytorch/kineto#1493) 328fa51 - Add XPU synchronization events to XPUPTI profiler (pytorch/kineto#1395) 8285e5b - Re-enable CI linting and lint all C++ (pytorch/kineto#1489) 2c41c01 - Test ConfigLoader handler fan-out (pytorch/kineto#1487) cccc5d1 - Update C++ lint tooling (pytorch/kineto#1488) 57e59e6 Pull Request resolved: #191526 Approved by: https://github.com/scotts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update a bunch of fields from int64_t to uint64_t:
Previously, for simplicity, we represented all of these as
int64_t, and just called static cast to move the fields that are actually produced asuint64_ttoint64_t. This was fine for JSON write, and the unsigned -> signed cast is safe, but the Perfetto logger represents many of these fields as unsigned. I'd like to avoid the unnecessary unsigned -> signed -> unsigned roundtrip and we recently added uint64_t as a TypedValue -- so we can accurately represent this now.All of the changes are used by Kineto only, so they should be safe.
kPythonParentIdis not used on the profiler side yet, so no compat issue there.Reviewed By: scotts
Differential Revision: D113458168