Test ConfigLoader on-demand daemon poll ingress (#1500) - #1500
Closed
scotts wants to merge 1 commit into
Closed
Conversation
|
@scotts has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113774357. |
meta-codesync
Bot
changed the title
scotts
added a commit
to scotts/kineto
that referenced
this pull request
Jul 27, 2026
Summary: Add unit tests for `ConfigLoader`'s update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic. Reviewed By: ryanzhang22 Differential Revision: D113774357
scotts
force-pushed
the
export-D113774357
branch
from
July 27, 2026 22:58
1e9fe73 to
d1340e9
Compare
scotts
added a commit
to scotts/kineto
that referenced
this pull request
Jul 28, 2026
Summary: Add unit tests for `ConfigLoader`'s update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic. Reviewed By: ryanzhang22 Differential Revision: D113774357
scotts
force-pushed
the
export-D113774357
branch
from
July 28, 2026 02:36
d1340e9 to
9c7704e
Compare
scotts
added a commit
to scotts/kineto
that referenced
this pull request
Jul 29, 2026
Summary: Add unit tests for `ConfigLoader`'s update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic. Reviewed By: ryanzhang22 Differential Revision: D113774357
scotts
force-pushed
the
export-D113774357
branch
from
July 29, 2026 00:35
9c7704e to
ab604ff
Compare
scotts
added a commit
to scotts/kineto
that referenced
this pull request
Jul 29, 2026
Summary: Add unit tests for `ConfigLoader`'s update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic. Reviewed By: ryanzhang22 Differential Revision: D113774357
scotts
force-pushed
the
export-D113774357
branch
from
July 29, 2026 00:35
ab604ff to
2b130ba
Compare
scotts
added a commit
to scotts/kineto
that referenced
this pull request
Jul 29, 2026
Summary: Add unit tests for `ConfigLoader`'s update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic. Reviewed By: ryanzhang22 Differential Revision: D113774357
scotts
force-pushed
the
export-D113774357
branch
from
July 29, 2026 00:38
2b130ba to
977d985
Compare
Summary: Add unit tests for `ConfigLoader`'s update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic. Reviewed By: ryanzhang22 Differential Revision: D113774357
scotts
force-pushed
the
export-D113774357
branch
from
July 29, 2026 10:40
977d985 to
32812ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add unit tests for
ConfigLoader's update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic.Reviewed By: ryanzhang22
Differential Revision: D113774357