Test ConfigLoader on-demand daemon poll ingress (#1504) - #1504
Merged
Conversation
|
@scotts has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114048073. |
Summary: This is a copy of D113774357, created because of landing problems with that diff. Add unit tests for `ConfigLoader`'s update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic. Reviewed By: NicolasHug Differential Revision: D114048073
meta-codesync
Bot
changed the title
scotts
force-pushed
the
export-D114048073
branch
from
July 29, 2026 14:47
6a06036 to
b0e5f47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a copy of D113774357, created because of landing problems with that diff.
Add unit tests for
ConfigLoader's update thread. This logic was previously untested. We add a basic counter to the actual thread which enables us to write deterministic tests that exercise the production logic.Reviewed By: NicolasHug
Differential Revision: D114048073