Repository navigation
Report Jackett setup errors in search results - #467
Closed
q5x-v6e-n7z-6x3 wants to merge 2 commits into
Closed
q5x-v6e-n7z-6x3 wants to merge 2 commits into
q5x-v6e-n7z-6x3 wants to merge 2 commits into
Conversation
Member
|
Please reopen #464 and push your changes there. I don't want to cross reference when reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show user-fixable Jackett setup errors in qBittorrent search results and stderr: a missing API key, an unreachable service, or no configured indexers. Check indexers even when
thread_countis 1. RaiseRuntimeErrorfor malformed XML and Jackett API errors, as requested in review. Updateversions.txtto 4.14.Split from #463 at the maintainer's request. This replaces #464 with the same reviewed commit; the review discussion remains available there.
Review notes
The test file now uses deferred annotations, eliminating the
typingimport-order conflict with Ruff and Pylint. Small typed response functions remain because strict Pyright rejects untyped inline lambdas passed tomonkeypatch.setattr.Testing