Skip to content

LT9611UXD#533

Open
mohitdsor wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
mohitdsor:drm-msm-fix
Open

LT9611UXD#533
mohitdsor wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
mohitdsor:drm-msm-fix

Conversation

@mohitdsor
Copy link
Copy Markdown

No description provided.

Add support for Lontium LT9611UXD HDMI bridge. Lontium LT9611UXD is a
DSI to HDMI bridge which supports DSI ports and I2S port as an input
and HDMI port as output. Despite name being similar to LT9611 and
LT9611UXD, these devices are different enough to warrant separate driver.

Signed-off-by: Mohit Dsor <mdsor@qti.qualcomm.com>
@mohitdsor mohitdsor changed the base branch from main to qcom-6.18.y May 3, 2026 19:47
@mohitdsor mohitdsor requested review from a team, jingyiwang42, ndechesne and shashim-quic May 3, 2026 19:47
Comment thread drivers/gpu/drm/bridge/lontium-lt9611uxd.c
Comment thread drivers/gpu/drm/bridge/lontium-lt9611uxd.c
{
.name = "register_range",
.range_min = 0,
.range_max = 0xffff,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct?

Comment thread drivers/gpu/drm/bridge/lontium-lt9611uxd.c
Comment thread drivers/gpu/drm/bridge/lontium-lt9611uxd.c
dev_err(dev, "failed to read HPD status\n");
} else {
lt9611uxd->hdmi_connected = (data[4] == 0x02);
dev_info(dev, "HDMI %s\n", lt9611uxd->hdmi_connected ? "connected" : "disconnected");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no info logs

lt9611uxd->supplies[1].supply = "vdd";

ret = devm_regulator_bulk_get(dev, 2, lt9611uxd->supplies);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no regulator_set_load?

return ret;
}

return ret;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return 0;

return MODE_BAD;
}

static void lt9611uxd_bridge_mode_set(struct drm_bridge *bridge,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this entire function needs to be rewritten according to lt9611uxc_video_setup

{
struct device *dev = lt9611uxd->dev;

lt9611uxd->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPIO_LOW?

return ret;
}

if (chipid[0] != 0x23 || chipid[1] != 0x06) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason of this hard coding and how to avoid

}
}

lt9611uxd_reset(lt9611uxd);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why reset again here

module_i2c_driver(lt9611uxd_driver);

MODULE_AUTHOR("mohit dsor <mohit.dsor@oss.qualcomm.com>");
MODULE_LICENSE("GPL v2");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

module_description needed?

Copy link
Copy Markdown

@quicvvalluru quicvvalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resubmit with updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants