ci(release): make release SDK builds hermetic (skip cross-run caches) - #1267
Open
Nathan Lu (NathanL15) wants to merge 1 commit into
Open
ci(release): make release SDK builds hermetic (skip cross-run caches)#1267Nathan Lu (NathanL15) wants to merge 1 commit into
Nathan Lu (NathanL15) wants to merge 1 commit into
Conversation
Nathan Lu (NathanL15)
force-pushed
the
ci/hermetic-release-builds
branch
from
July 31, 2026 22:54
3855691 to
c7a9ea8
Compare
Release artifacts should not depend on cross-run mutable caches (ccache, cargo target, restored ninja tree); the cargo cache comment in this file records one stale-artifact incident already. hermetic defaults to false, so only the release build pays the clean-build cost. Signed-off-by: Nathan Lu <lunathan2005@gmail.com>
Nathan Lu (NathanL15)
force-pushed
the
ci/hermetic-release-builds
branch
from
July 31, 2026 22:59
c7a9ea8 to
f7a5e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
hermeticinput to_build-sdk.ymlthat skips the three cross-run cache restores (ccache, cargo target, CMake build tree), and sets it for thebuild-sdkcall inrelease.yml. Defaults tofalse, so PR/branch builds and every other caller keep their caches; only release artifacts pay the clean-build cost (one ~30–60 min build per release, inside the job's 120-minute timeout).Rationale: shipped artifacts shouldn't depend on cross-run mutable state. The cargo-target cache comment in this file already records one stale-artifact incident in this pipeline; a hermetic release build removes that entire class for the binaries users install, whatever the mechanism of any individual incident.
Scope note, to be upfront: I verified that
actions/cacheextracts with archived mtimes (no-m), so ninja's staleness detection should normally be sound — this is defense-in-depth for releases, not a fix for a demonstrated bug, and it is independent of #1266 (which it came out of investigating). If you consider the current caches sufficient, closing this is a reasonable call.