Skip to content

249 include timings #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zleyyij merged 3 commits into from
Aug 3, 2026
Merged

249 include timings #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8186b18
feat(backend): trace timings now a CLI argument
zleyyij Aug 3, 2026
c7584fe
Merge branch 'main' into 249-include-timings
zleyyij Aug 3, 2026
f46b022
fix(backend): logs are now only timestamped when --include-timings is…
zleyyij Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 53 additions & 62 deletions backend/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 9 additions & 4 deletions backend/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ use std::sync::LazyLock;
use std::time::Duration;
use tracing::{Level, Span};
use tracing::{debug, info, info_span, warn};
use tracing_subscriber::fmt::format::FmtSpan;

use crate::app_conf::AppConf;
use tokio::task;
Expand Down Expand Up @@ -70,6 +71,8 @@ struct Args {
.map(|s| s.to_lowercase().parse::<Level>().unwrap())
)]
logging_level: Level,
#[arg(long = "include-timings", help = "Whether or not to log span duration")]
include_timings: bool,
#[arg(
short = 'c',
long = "config",
Expand All @@ -85,10 +88,12 @@ async fn main() -> Result<()> {
// Parse command line arguments
let cli_args = Args::parse();
// Initialize logging
tracing_subscriber::fmt()
.with_max_level(cli_args.logging_level)
.without_time()
.init();
let subscriber = tracing_subscriber::fmt().with_max_level(cli_args.logging_level);
if cli_args.include_timings {
subscriber.with_span_events(FmtSpan::CLOSE).init();
} else {
subscriber.without_time().init();
}
debug!("Initialized logging");

if cfg!(debug_assertions) {
Expand Down