Add time span info to set_*_host() messages - #799
Merged
Conversation
Print elapsed time after setting GitHub/GitLab hosts, matching the pattern used by get_*() functions. Co-authored-by: Ona <no-reply@ona.com>
marcinkowskak
approved these changes
May 4, 2026
…_*_host, therefore snapshot tests are not a good choice here.
Co-authored-by: Ona <no-reply@ona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Print elapsed time after setting GitHub/GitLab hosts (e.g.
ℹ Set up in 1.2 secs.), matching the pattern already used by allget_*()functions. The message respects theverboseflag and is not emitted when the host setup errors out.Related Issue(s)
Fixes #798
How to test
set_github_host()orset_gitlab_host()withverbose = TRUEand verify the elapsed time message appears after✔ Set connection to GitHub/GitLab.verbose = FALSEand verify no time message is printed.