chore(store): centralize KeepKey dropship mode default in config#134
Merged
Conversation
Add KEEPKEY_DROPSHIP_MODE to src/lib/config.ts as the single default ("test"),
mirroring the store checkout wallet. isSandbox() still reads the env var at
call-time so Vercel can flip live/test without a redeploy — the config const is
the fallback default. Default stays "test" deliberately: going live is an env
flip, never a side effect of a deploy.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KEEPKEY_DROPSHIP_MODEnow has its default insrc/lib/config.ts, mirroringSTORE_CHECKOUT.recipient.isSandbox()still reads the env var at call-time (so Vercel can flip live/test without a redeploy), with the config const as the fallback default.testdeliberately — going live is an env flip, never a side effect of a deploy.Changes
src/lib/config.ts— newKEEPKEY_DROPSHIP_MODEconst (env override →"test"default).src/services/keepkey-dropship.ts—isSandbox()uses env ?? config default.env.example,docs/integrations/keepkey-fulfillment.md— note the config default.Test plan
pnpm test— 115 passing (mode-dependent webhook tests still flip via env)test;KEEPKEY_DROPSHIP_MODE=live→livepnpm lint+tsccleanGenerated with Claude Code