chore(store): make dropship mode config-only (drop env read)#135
Merged
Conversation
isSandbox() now reads KEEPKEY_DROPSHIP_MODE from src/lib/config.ts only — the env var is no longer consulted. Going live means editing config.ts to "live" and shipping; the Vercel KEEPKEY_DROPSHIP_MODE env (if any) is ignored. Default stays "test". Tests drive the mode via a mocked config value instead of env. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KEEPKEY_DROPSHIP_MODEinsrc/lib/config.ts. The Vercel env var is no longer read.KEEPKEY_DROPSHIP_MODE = "live"in config and ship. Default stays"test".Changes
src/lib/config.ts—KEEPKEY_DROPSHIP_MODEis a plain hardcoded const (no env read).src/services/keepkey-dropship.ts—isSandbox()reads the config const only.src/services/keepkey-dropship.test.ts— mode driven via a mocked config value (not env).env.example,docs/integrations/keepkey-fulfillment.md— mode noted as code-set, removed from env list.Test plan
pnpm test— 115 passingpnpm lint+tsccleanGenerated with Claude Code