Repository navigation
fix(neutron-understack): select the ACTIVE port binding, not bindings[0] - #2464
Merged
Merged
Conversation
Indexing port.bindings[0] assumes the binding order and picks the wrong binding for a port with an INACTIVE binding alongside the ACTIVE one, as happens during live migration. Add utils.active_port_binding(), which wraps neutron-lib's get_port_binding_by_status_and_host(), and use it in parent_port_is_bound(), the trunk code and the undersync driver. A port with no active binding is now reported as not bound. Document the dict, OVO and SQLAlchemy model port representations and how to select a binding from each in the Neutron networking design guide.
Python test results497 tests 497 ✅ 3s ⏱️ Results for commit c48fb5a. |
haseebsyed12
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexing port.bindings[0] assumes the binding order and picks the wrong
binding for a port with an INACTIVE binding alongside the ACTIVE one, as
happens during live migration.
Add utils.active_port_binding(), which wraps neutron-lib's
get_port_binding_by_status_and_host(), and use it in
parent_port_is_bound(), the trunk code and the undersync driver. A port
with no active binding is now reported as not bound.
Document the dict, OVO and SQLAlchemy model port representations and how
to select a binding from each in the Neutron networking design guide.
Today this has no impact on how our code runs but in the future with
centralized HA ports, we could have INACTIVE bindings where the port
currently does not live.