Skip to content

Fix relative paths in Git revision headers - #1101

Closed
fallintoplace wants to merge 1 commit into
rapidsai:mainfrom
fallintoplace:fix-relative-git-revision-path
Closed

fallintoplace wants to merge 1 commit into
rapidsai:mainfrom
fallintoplace:fix-relative-git-revision-path

Conversation

@fallintoplace

Copy link
Copy Markdown

Description

What

  • Fix relative paths in rapids_cmake_write_git_revision_file.

Why

  • Nested paths fail CMake generation. Plain filenames write headers into the source directory.

Implementation

  • Use the resolved build path for output, byproducts, and includes.
  • Add regression coverage for plain filenames and nested paths with spaces.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
@fallintoplace
fallintoplace requested a review from a team as a code owner October 4, 2026 18:54
@copy-pr-bot

copy-pr-bot Bot commented Oct 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 5, 2026
@KyleFromNVIDIA

Copy link
Copy Markdown
Member

Closing as very few of our projects use this feature, and none hit the code path that's being fixed. If this issue comes up in RAPIDS, we can revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants