Skip to content

[docs] Polish the Ray Sandboxes networking section - #65863

Merged
dstrodtman merged 1 commit into
masterfrom
djs-260902-sandbox-net-feedback
Sep 2, 2026
Merged

[docs] Polish the Ray Sandboxes networking section#65863
dstrodtman merged 1 commit into
masterfrom
djs-260902-sandbox-net-feedback

Conversation

@dstrodtman

Copy link
Copy Markdown
Contributor

Applies the review feedback from the 2.58.0 cherry-pick (#65734) back to master, so the two don't diverge. The original style pass (#65627) landed on master before that feedback came in.

Prose-only, no behavior or API changes:

  • Drop non-standard trailing equal signs from parameter references: network=, dns=, and capabilities= become network, dns, and capabilities. The real capabilities=[] code call is left as-is.
  • Reword the awkward "where the public defaults can't resolve" into "so the default public DNS settings can't resolve queries."
  • Spell out virtual private clouds (VPCs) on first use, matching the existing "virtual machines (VMs)" treatment, and define Open Container Initiative (OCI) at its first prose use. OCI is defined in prose rather than the heading to preserve the #pass-custom-oci-configurations-to-gvisor anchor.

🤖 Generated with Claude Code

Drop non-standard trailing equal signs from parameter references
(network, dns, capabilities), fix awkward DNS phrasing, and spell out
VPC and OCI on first use. Keeps master in sync with the review feedback
applied on the 2.58.0 cherry-pick.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
@dstrodtman
dstrodtman requested review from a team as code owners September 2, 2026 15:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in doc/source/ray-core/sandboxes.md to improve clarity and formatting. Key changes include expanding acronyms like 'OCI' and 'VPCs' to 'Open Container Initiative (OCI)' and 'virtual private clouds (VPCs)', clarifying DNS resolution behavior, and removing trailing equals signs from configuration option references (e.g., changing network= to network). There are no review comments, and I have no additional feedback to provide.

@dstrodtman dstrodtman added go add ONLY when ready to merge, run all tests docs-go RtD-only checks for docs-only changes. Doesn't run full library doc-test suites. labels Sep 2, 2026
@dstrodtman
dstrodtman enabled auto-merge (squash) September 2, 2026 15:23
@dstrodtman
dstrodtman merged commit 45d58f8 into master Sep 2, 2026
7 checks passed
@dstrodtman
dstrodtman deleted the djs-260902-sandbox-net-feedback branch September 2, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-go RtD-only checks for docs-only changes. Doesn't run full library doc-test suites. go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants